<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/15954">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm: Fix compilation error under some compilers<br><br>Some compilers don't like declaration of enums in header files like we<br>do sometimes for structs:<br>enum gsm_band;<br>void foobar(enum gsm_band band);<br><br>triggers:<br>error: use of enum 'gsm_band' without previous declaration<br><br>Fixes: b99f4ca2d8517d99cdf8aa183dbfda7b233bb781<br>Related: OS#4244<br>Change-Id: I6c2102c763f565bbe3c8dd7e5b4e04c4a45fff67<br>---<br>M include/osmocom/gsm/gsm_utils.h<br>M include/osmocom/gsm/protocol/gsm_04_08.h<br>2 files changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/54/15954/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/gsm/gsm_utils.h b/include/osmocom/gsm/gsm_utils.h</span><br><span>index 7a5da9a..38a3f6e 100644</span><br><span>--- a/include/osmocom/gsm/gsm_utils.h</span><br><span>+++ b/include/osmocom/gsm/gsm_utils.h</span><br><span>@@ -30,7 +30,6 @@</span><br><span> </span><br><span> #include <osmocom/core/defs.h></span><br><span> #include <osmocom/core/utils.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/gsm/protocol/gsm_04_08.h></span><br><span> </span><br><span> #define ADD_MODULO(sum, delta, modulo) do {      \</span><br><span>    if ((sum += delta) >= modulo)                \</span><br><span>diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h b/include/osmocom/gsm/protocol/gsm_04_08.h</span><br><span>index b5317d5..68ec4e3 100644</span><br><span>--- a/include/osmocom/gsm/protocol/gsm_04_08.h</span><br><span>+++ b/include/osmocom/gsm/protocol/gsm_04_08.h</span><br><span>@@ -9,8 +9,9 @@</span><br><span> #include <osmocom/core/utils.h></span><br><span> #include <osmocom/core/endian.h></span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/gsm/gsm_utils.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> struct gsm_lchan;</span><br><span style="color: hsl(0, 100%, 40%);">-enum gsm_band;</span><br><span> </span><br><span> /* Chapter 10.5.1.5 */</span><br><span> struct gsm48_classmark1 {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/15954">change 15954</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/15954"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6c2102c763f565bbe3c8dd7e5b4e04c4a45fff67 </div>
<div style="display:none"> Gerrit-Change-Number: 15954 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>