<p>neels <strong>uploaded patch set #4</strong> to this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/15913">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">add db_upgrade test<br><br>We have a database schema upgrade path, but so far nothing that verifies that<br>we don't break it. It almost seems like the user data weren't important to us!?<br><br>Add a db upgrade test:<br>- Create a db with an .sql dump taken from a db created with an old osmo-hlr,<br>  producing DB schema version 0.<br>- Run osmo-hlr --db-upgrade --db-check<br>- Verify that the upgrade exited successfully.<br>- Verify that restarting with the upgraded DB works.<br><br>If python tests are enabled, also:<br>- create a new database using the new osmo-hlr (just built).<br>- replay a VTY transcript to create subscribers as in the old snapshot.<br>- replay some sql modifications as done in the old snapshot.<br>- Get a list of sorted table names,<br>- a list of their sorted columns with all their properties,<br>- and dump the table contents in a column- and value-sorted way.<br>- Compare the resulting dumps and error if there are any diffs.<br>(This is how I found the difference in the imei column that was fixed in<br>I68a00014a3d603fcba8781470bc5285f78b538d0)<br><br>Change-Id: I0961bab0e17cfde5b030576c5bc243c2b51d9dc4<br>---<br>M configure.ac<br>M tests/Makefile.am<br>A tests/db_upgrade/Makefile.am<br>A tests/db_upgrade/create_subscribers.vty<br>A tests/db_upgrade/create_subscribers_step2.sql<br>A tests/db_upgrade/db_upgrade_test.err<br>A tests/db_upgrade/db_upgrade_test.ok<br>A tests/db_upgrade/db_upgrade_test.sh<br>A tests/db_upgrade/hlr_db_v0.sql<br>A tests/db_upgrade/osmo-hlr.cfg<br>M tests/testsuite.at<br>11 files changed, 416 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/13/15913/4</pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hlr/+/15913">change 15913</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hlr/+/15913"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0961bab0e17cfde5b030576c5bc243c2b51d9dc4 </div>
<div style="display:none"> Gerrit-Change-Number: 15913 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>