<p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/15916">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/15916/2/src/gsup_server.c">File src/gsup_server.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/15916/2/src/gsup_server.c@66">Patch Set #2, Line 66:</a> <code style="font-family:monospace,monospace">only REQUESTs need an error reply</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Probably, makes sense to print a warning then.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/15916/2/src/gsup_server.c@88">Patch Set #2, Line 88:</a> <code style="font-family:monospace,monospace">OSMO_ASSERT</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">osmo_gsup_msgb_alloc() also assert()s the result of allocation, so this is redundant.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/15916/2/src/gsup_server.c@89">Patch Set #2, Line 89:</a> <code style="font-family:monospace,monospace">osmo_gsup_encode</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should we check if encoding failed?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hlr/+/15916">change 15916</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hlr/+/15916"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I792fd9993ab2a323af58782a357d71205c43b72a </div>
<div style="display:none"> Gerrit-Change-Number: 15916 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 31 Oct 2019 18:42:39 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>