<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15883">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: Verify ms power level value from RSL IE MS Power during CHAN ACT<br><br>Change-Id: I0a632156420251b14d1bbfd4ca19dc2bdf5a5f1e<br>---<br>M bsc/MSC_ConnectionHandler.ttcn<br>M library/RSL_Types.ttcn<br>2 files changed, 17 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn</span><br><span>index 40701d6..8091d8d 100644</span><br><span>--- a/bsc/MSC_ConnectionHandler.ttcn</span><br><span>+++ b/bsc/MSC_ConnectionHandler.ttcn</span><br><span>@@ -526,6 +526,7 @@</span><br><span> TestHdlrEncrParams encr optional,</span><br><span> TestHdlrParamsLcls lcls,</span><br><span> TestHdlrParamsHandover handover optional,</span><br><span style="color: hsl(120, 100%, 40%);">+ uint5_t exp_ms_power_level,</span><br><span> boolean aoip,</span><br><span> boolean use_osmux</span><br><span> };</span><br><span>@@ -551,6 +552,7 @@</span><br><span> adjust_cx_exp := true</span><br><span> },</span><br><span> handover := omit,</span><br><span style="color: hsl(120, 100%, 40%);">+ exp_ms_power_level := 7, /* calculated from osmo-bsc.cfg "ms max power" */</span><br><span> aoip := true,</span><br><span> use_osmux := false</span><br><span> }</span><br><span>@@ -739,6 +741,7 @@</span><br><span> private function f_check_chan_act(AssignmentState st, RSL_Message chan_act) runs on MSC_ConnHdlr {</span><br><span> var RSL_IE_Body encr_info;</span><br><span> var RSL_IE_Body ms_power_param;</span><br><span style="color: hsl(120, 100%, 40%);">+ var RSL_IE_Body ms_power;</span><br><span> </span><br><span> if (ispresent(g_pars.encr) and g_pars.encr.enc_alg != '01'O) {</span><br><span> if (not f_rsl_find_ie(chan_act, RSL_IE_ENCR_INFO, encr_info)) {</span><br><span>@@ -763,6 +766,14 @@</span><br><span> Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "IE MS Power Parameters not found in CHAN ACT");</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ if (not f_rsl_find_ie(chan_act, RSL_IE_MS_POWER, ms_power)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "IE MS Power not found in CHAN ACT");</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (not match(ms_power.ms_power, tr_RSL_IE_MS_Power(g_pars.exp_ms_power_level, false))) {</span><br><span style="color: hsl(120, 100%, 40%);">+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Wrong MS Power IE in CHAN ACT");</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> }</span><br><span> </span><br><span> altstep as_assignment(inout AssignmentState st) runs on MSC_ConnHdlr {</span><br><span>diff --git a/library/RSL_Types.ttcn b/library/RSL_Types.ttcn</span><br><span>index db0e231..d982e02 100644</span><br><span>--- a/library/RSL_Types.ttcn</span><br><span>+++ b/library/RSL_Types.ttcn</span><br><span>@@ -454,6 +454,12 @@</span><br><span> boolean fpc_epc,</span><br><span> uint5_t power_level</span><br><span> }</span><br><span style="color: hsl(120, 100%, 40%);">+ template RSL_IE_MS_Power tr_RSL_IE_MS_Power(template uint5_t power_level := ?,</span><br><span style="color: hsl(120, 100%, 40%);">+ template boolean fpc_epc := false) := {</span><br><span style="color: hsl(120, 100%, 40%);">+ reserved := 0,</span><br><span style="color: hsl(120, 100%, 40%);">+ fpc_epc := fpc_epc,</span><br><span style="color: hsl(120, 100%, 40%);">+ power_level := power_level</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> template (value) RSL_IE_MS_Power ts_RSL_IE_MS_Power(uint5_t power_level,</span><br><span> boolean fpc_epc := false) := {</span><br><span> reserved := 0,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15883">change 15883</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15883"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0a632156420251b14d1bbfd4ca19dc2bdf5a5f1e </div>
<div style="display:none"> Gerrit-Change-Number: 15883 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>