<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/15874">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">xua: Verify all route ctxs received in ASPAC msg<br><br>Change-Id: I16ad0847d671522c8942b441db7e4c460f4f142b<br>---<br>M src/xua_asp_fsm.c<br>1 file changed, 10 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c</span><br><span>index db4ffcb..1b39639 100644</span><br><span>--- a/src/xua_asp_fsm.c</span><br><span>+++ b/src/xua_asp_fsm.c</span><br><span>@@ -416,6 +416,9 @@</span><br><span>         struct osmo_ss7_asp *asp = xafp->asp;</span><br><span>     struct xua_msg *xua_in;</span><br><span>      uint32_t traf_mode;</span><br><span style="color: hsl(120, 100%, 40%);">+   struct xua_msg_part *part;</span><br><span style="color: hsl(120, 100%, 40%);">+    uint32_t rctx;</span><br><span style="color: hsl(120, 100%, 40%);">+        int i;</span><br><span> </span><br><span>   check_stop_t_ack(fi, event);</span><br><span>         switch (event) {</span><br><span>@@ -456,11 +459,13 @@</span><br><span>                             break;</span><br><span>                       }</span><br><span>            }</span><br><span style="color: hsl(0, 100%, 40%);">-               if (xua_msg_find_tag(xua_in, M3UA_IEI_ROUTE_CTX)) {</span><br><span style="color: hsl(0, 100%, 40%);">-                     uint32_t rctx = xua_msg_get_u32(xua_in, M3UA_IEI_ROUTE_CTX);</span><br><span style="color: hsl(0, 100%, 40%);">-                    if (!osmo_ss7_as_find_by_rctx(asp->inst, rctx)) {</span><br><span style="color: hsl(0, 100%, 40%);">-                            peer_send_error(fi, M3UA_ERR_INVAL_ROUT_CTX);</span><br><span style="color: hsl(0, 100%, 40%);">-                           break;</span><br><span style="color: hsl(120, 100%, 40%);">+                if ((part = xua_msg_find_tag(xua_in, M3UA_IEI_ROUTE_CTX))) {</span><br><span style="color: hsl(120, 100%, 40%);">+                  for (i = 0; i < part->len / sizeof(uint32_t); i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+                            rctx = osmo_load32be(&part->dat[i * sizeof(uint32_t)]);</span><br><span style="color: hsl(120, 100%, 40%);">+                                if (!osmo_ss7_as_find_by_rctx(asp->inst, rctx)) {</span><br><span style="color: hsl(120, 100%, 40%);">+                                  peer_send_error(fi, M3UA_ERR_INVAL_ROUT_CTX);</span><br><span style="color: hsl(120, 100%, 40%);">+                                 break;</span><br><span style="color: hsl(120, 100%, 40%);">+                                }</span><br><span>                    }</span><br><span>            }</span><br><span>            /* send ACK */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/15874">change 15874</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-sccp/+/15874"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I16ad0847d671522c8942b441db7e4c460f4f142b </div>
<div style="display:none"> Gerrit-Change-Number: 15874 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>