<p style="white-space: pre-wrap; word-wrap: break-word;">I'd welcome having also split into different commits:<br>1- Moving all existing fields into the new struct<br>2- Ading whatever fields are required and implementing the feature.</p><p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/15838">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/15838/1/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c">File src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/15838/1/src/libosmo-mgcp-client/mgcp_client_endpoint_fsm.c@701">Patch Set #1, Line 701:</a> <code style="font-family:monospace,monospace">struct osmo_mgcpc_ep *osmo_mgcpc_ep_ci_ep(struct osmo_mgcpc_ep_ci *conn)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This new API looks non related to the commit.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-mgw/+/15838">change 15838</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-mgw/+/15838"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I41687d7f3a808587ab7f7520f46dcc3c29cff92d </div>
<div style="display:none"> Gerrit-Change-Number: 15838 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 23 Oct 2019 13:39:54 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>