<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/15830">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Log correct protocol during xua_accept_cb()<br><br>This function is used for both actual SIGTRAN (M3UA, SUA over SCTP)<br>as well as for IPA/SCCPLITE (over TCP).  Having a static "SCTP"<br>string in the log lines is confusing.<br><br>Change-Id: Ic34ddbcd528cd871d9772665e1d0863896f33203<br>---<br>M src/osmo_ss7.c<br>1 file changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c</span><br><span>index 88c4922..464f2f4 100644</span><br><span>--- a/src/osmo_ss7.c</span><br><span>+++ b/src/osmo_ss7.c</span><br><span>@@ -1710,9 +1710,9 @@</span><br><span>   struct osmo_stream_srv *srv;</span><br><span>         struct osmo_ss7_asp *asp;</span><br><span>    char *sock_name = osmo_sock_get_name(link, fd);</span><br><span style="color: hsl(120, 100%, 40%);">+       const char *proto_name = get_value_string(osmo_ss7_asp_protocol_vals, oxs->cfg.proto);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   LOGP(DLSS7, LOGL_INFO, "%s: New %s connection accepted\n",</span><br><span style="color: hsl(0, 100%, 40%);">-            sock_name, get_value_string(osmo_ss7_asp_protocol_vals, oxs->cfg.proto));</span><br><span style="color: hsl(120, 100%, 40%);">+  LOGP(DLSS7, LOGL_INFO, "%s: New %s connection accepted\n", sock_name, proto_name);</span><br><span> </span><br><span>     if (oxs->cfg.proto == OSMO_SS7_ASP_PROT_IPA) {</span><br><span>            srv = osmo_stream_srv_create(oxs, link, fd,</span><br><span>@@ -1737,9 +1737,9 @@</span><br><span>                  sock_name, asp->cfg.name);</span><br><span>        } else {</span><br><span>             if (!oxs->cfg.accept_dyn_reg) {</span><br><span style="color: hsl(0, 100%, 40%);">-                      LOGP(DLSS7, LOGL_NOTICE, "%s: SCTP connection without matching "</span><br><span style="color: hsl(120, 100%, 40%);">+                    LOGP(DLSS7, LOGL_NOTICE, "%s: %s connection without matching "</span><br><span>                          "ASP definition and no dynamic registration enabled, terminating\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                          sock_name);</span><br><span style="color: hsl(120, 100%, 40%);">+                           sock_name, proto_name);</span><br><span>                 } else {</span><br><span>                     char namebuf[32];</span><br><span>                    static uint32_t dyn_asp_num = 0;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/15830">change 15830</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-sccp/+/15830"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic34ddbcd528cd871d9772665e1d0863896f33203 </div>
<div style="display:none"> Gerrit-Change-Number: 15830 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>