<p>osmith has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/15805">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty.c: remove assert for always true condition<br><br>Remove OSMO_ASSERT(sapi != -EINVAL) statements, because sapi is an<br>uint8_t and therefore can never be less than zero.<br><br>Fixes: CID#205066, CID#205069<br>Change-Id: I4d30afacfab93051868ae8f462cee9ad3dbc7fd0<br>---<br>M src/common/vty.c<br>1 file changed, 0 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/05/15805/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/vty.c b/src/common/vty.c</span><br><span>index 865c236..7c043e1 100644</span><br><span>--- a/src/common/vty.c</span><br><span>+++ b/src/common/vty.c</span><br><span>@@ -1607,7 +1607,6 @@</span><br><span>     struct log_target *tgt = osmo_log_vty2tgt(vty);</span><br><span>      uint16_t **sapi_mask;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       OSMO_ASSERT(sapi != -EINVAL);</span><br><span>        if (!tgt)</span><br><span>            return CMD_WARNING;</span><br><span> </span><br><span>@@ -1628,7 +1627,6 @@</span><br><span>      struct log_target *tgt = osmo_log_vty2tgt(vty);</span><br><span>      uint16_t *sapi_mask;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        OSMO_ASSERT(sapi != -EINVAL);</span><br><span>        if (!tgt)</span><br><span>            return CMD_WARNING;</span><br><span>  if (!tgt->filter_data[LOG_FLT_L1_SAPI])</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/15805">change 15805</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/15805"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4d30afacfab93051868ae8f462cee9ad3dbc7fd0 </div>
<div style="display:none"> Gerrit-Change-Number: 15805 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>