<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/15780">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sigtran: Set default remote ip to localhost instead of null<br><br>NULL or 0.0.0.0 should actually not be used upon connect() calls.<br>Whoever, it worked so far because osmo_sock_init2() calls getaddrinfo()<br>on it which does the 0.0.0.0->127.0.0.1 translation.<br>osmo-msc already passed 127.0.0.1 as default address, so let's do the<br>same here.<br><br>Change-Id: Ib0d33c66faab78e609742638425cb8a0c382406f<br>---<br>M src/osmo-bsc/osmo_bsc_sigtran.c<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c</span><br><span>index 0bf48a7..543e6de 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_sigtran.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_sigtran.c</span><br><span>@@ -44,6 +44,7 @@</span><br><span> #define RESET_INTERVAL 1     /* sek */</span><br><span> #define SCCP_MSG_MAXSIZE 1024</span><br><span> #define CS7_POINTCODE_DEFAULT_OFFSET 2</span><br><span style="color: hsl(120, 100%, 40%);">+#define DEFAULT_ASP_REMOTE_IP "127.0.0.1"</span><br><span> </span><br><span> /* The SCCP stack will not assign connection IDs to us automatically, we</span><br><span>  * will do this ourselves using a counter variable, that counts one up</span><br><span>@@ -514,7 +515,7 @@</span><br><span>            default_pc = osmo_ss7_pointcode_parse(NULL, BSC_DEFAULT_PC);</span><br><span>                 msc->a.sccp =</span><br><span>                 osmo_sccp_simple_client_on_ss7_id(msc, msc->a.cs7_instance, msc_name, default_pc,</span><br><span style="color: hsl(0, 100%, 40%);">-                                                      msc->a.asp_proto, 0, NULL, 0, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+                                               msc->a.asp_proto, 0, NULL, 0, DEFAULT_ASP_REMOTE_IP);</span><br><span>               if (!msc->a.sccp)</span><br><span>                         return -EINVAL;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/15780">change 15780</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/15780"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib0d33c66faab78e609742638425cb8a0c382406f </div>
<div style="display:none"> Gerrit-Change-Number: 15780 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>