<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15744">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cuart_[fsm]_test: Avoid hard-coded 'ttyUSB5'; use command line arg<br><br>Change-Id: I0b66ed7c037376e4a5a9283cb972012594bc35d2<br>---<br>M ccid_host/cuart_fsm_test.c<br>M ccid_host/cuart_test.c<br>2 files changed, 16 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ccid_host/cuart_fsm_test.c b/ccid_host/cuart_fsm_test.c</span><br><span>index 92f3437..1151b34 100644</span><br><span>--- a/ccid_host/cuart_fsm_test.c</span><br><span>+++ b/ccid_host/cuart_fsm_test.c</span><br><span>@@ -61,7 +61,14 @@</span><br><span> </span><br><span> signal(SIGUSR1, &signal_handler);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- rc = card_uart_open(&g_cuart, "tty", "/dev/ttyUSB5");</span><br><span style="color: hsl(120, 100%, 40%);">+ if (argc < 2) {</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "You must specify the UART tty device as argument\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ exit(2);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("Opening UART device %s\n", argv[1]);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ rc = card_uart_open(&g_cuart, "tty", argv[1]);</span><br><span> if (rc < 0) {</span><br><span> perror("opening UART");</span><br><span> exit(1);</span><br><span>diff --git a/ccid_host/cuart_test.c b/ccid_host/cuart_test.c</span><br><span>index 0ed6614..e2b1ce2 100644</span><br><span>--- a/ccid_host/cuart_test.c</span><br><span>+++ b/ccid_host/cuart_test.c</span><br><span>@@ -58,8 +58,15 @@</span><br><span> uint8_t atr[64];</span><br><span> int rc;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ if (argc < 2) {</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "You must specify the UART tty device as argument\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ exit(2);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ printf("Opening UART device %s\n", argv[1]);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> g_cuart.handle_event = &handle_event;</span><br><span style="color: hsl(0, 100%, 40%);">- rc = card_uart_open(&g_cuart, "tty", "/dev/ttyUSB5");</span><br><span style="color: hsl(120, 100%, 40%);">+ rc = card_uart_open(&g_cuart, "tty", argv[1]);</span><br><span> if (rc < 0) {</span><br><span> perror("opening UART");</span><br><span> exit(1);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15744">change 15744</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15744"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ccid-firmware </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0b66ed7c037376e4a5a9283cb972012594bc35d2 </div>
<div style="display:none"> Gerrit-Change-Number: 15744 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>