<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15756">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ccid_slot_fsm: Add msgb_hexdump of TPDU and ATR as it passes by<br><br>Change-Id: I347b1a44c51624ca16b0687a92454f96c3cb20ab<br>---<br>M ccid_common/ccid_slot_fsm.c<br>1 file changed, 8 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ccid_common/ccid_slot_fsm.c b/ccid_common/ccid_slot_fsm.c</span><br><span>index 7b513a5..a7ecb9f 100644</span><br><span>--- a/ccid_common/ccid_slot_fsm.c</span><br><span>+++ b/ccid_common/ccid_slot_fsm.c</span><br><span>@@ -87,12 +87,11 @@</span><br><span>         struct ccid_slot *cs = ss->cs;</span><br><span>    struct msgb *tpdu, *resp;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   LOGPCS(cs, LOGL_DEBUG, "%s(event=%d, cause=%d, data=%p)\n", __func__, event, cause, data);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>         switch (event) {</span><br><span>     case ISO7816_E_ATR_DONE_IND:</span><br><span>                 tpdu = data;</span><br><span style="color: hsl(0, 100%, 40%);">-            /* FIXME: copy response data over */</span><br><span style="color: hsl(120, 100%, 40%);">+          LOGPCS(cs, LOGL_DEBUG, "%s(event=%d, cause=%d, data=%s)\n", __func__, event, cause,</span><br><span style="color: hsl(120, 100%, 40%);">+                 msgb_hexdump(tpdu));</span><br><span>                 resp = ccid_gen_data_block(cs, ss->seq, CCID_CMD_STATUS_OK, 0,</span><br><span>                                       msgb_data(tpdu), msgb_length(tpdu));</span><br><span>              ccid_slot_send_unbusy(cs, resp);</span><br><span>@@ -100,11 +99,16 @@</span><br><span>              break;</span><br><span>       case ISO7816_E_TPDU_DONE_IND:</span><br><span>                tpdu = data;</span><br><span style="color: hsl(0, 100%, 40%);">-            /* FIXME: copy response data over */</span><br><span style="color: hsl(120, 100%, 40%);">+          LOGPCS(cs, LOGL_DEBUG, "%s(event=%d, cause=%d, data=%s)\n", __func__, event, cause,</span><br><span style="color: hsl(120, 100%, 40%);">+                 msgb_hexdump(tpdu));</span><br><span>                 resp = ccid_gen_data_block(cs, ss->seq, CCID_CMD_STATUS_OK, 0, msgb_l2(tpdu), msgb_l2len(tpdu));</span><br><span>          ccid_slot_send_unbusy(cs, resp);</span><br><span>             msgb_free(tpdu);</span><br><span>             break;</span><br><span style="color: hsl(120, 100%, 40%);">+        default:</span><br><span style="color: hsl(120, 100%, 40%);">+              LOGPCS(cs, LOGL_NOTICE, "%s(event=%d, cause=%d, data=%p) unhandled\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                      __func__, event, cause, data);</span><br><span style="color: hsl(120, 100%, 40%);">+                break;</span><br><span>       }</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15756">change 15756</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15756"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ccid-firmware </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I347b1a44c51624ca16b0687a92454f96c3cb20ab </div>
<div style="display:none"> Gerrit-Change-Number: 15756 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>