<p>lynxis lazus <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15704">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sgsn_mm_ctx_alloc(): check for unallocated fsms<br><br>Change-Id: I867612a60236eaf7009400c92f5d871006aaf008<br>---<br>M src/sgsn/gprs_sgsn.c<br>1 file changed, 25 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sgsn/gprs_sgsn.c b/src/sgsn/gprs_sgsn.c</span><br><span>index 474f8f9..cb2c0fc 100644</span><br><span>--- a/src/sgsn/gprs_sgsn.c</span><br><span>+++ b/src/sgsn/gprs_sgsn.c</span><br><span>@@ -243,17 +243,42 @@</span><br><span>                 talloc_free(ctx);</span><br><span>            return NULL;</span><br><span>         }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  ctx->gmm_fsm = osmo_fsm_inst_alloc(&gmm_fsm, ctx, ctx, LOGL_DEBUG, "gmm_fsm");</span><br><span style="color: hsl(120, 100%, 40%);">+       if (!ctx->gmm_fsm)</span><br><span style="color: hsl(120, 100%, 40%);">+         goto out;</span><br><span>    ctx->gmm_att_req.fsm = osmo_fsm_inst_alloc(&gmm_attach_req_fsm, ctx, ctx, LOGL_DEBUG, "gb_gmm_req");</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!ctx->gmm_att_req.fsm)</span><br><span style="color: hsl(120, 100%, 40%);">+         goto out;</span><br><span>    ctx->gb.mm_state_fsm = osmo_fsm_inst_alloc(&mm_state_gb_fsm, ctx, ctx, LOGL_DEBUG, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+      if (!ctx->gb.mm_state_fsm)</span><br><span style="color: hsl(120, 100%, 40%);">+         goto out;</span><br><span> #ifdef BUILD_IU</span><br><span>         ctx->iu.mm_state_fsm = osmo_fsm_inst_alloc(&mm_state_iu_fsm, ctx, ctx, LOGL_DEBUG, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+      if (!ctx->iu.mm_state_fsm)</span><br><span style="color: hsl(120, 100%, 40%);">+         goto out;</span><br><span> #endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>        INIT_LLIST_HEAD(&ctx->pdp_list);</span><br><span> </span><br><span>  llist_add(&ctx->list, &sgsn_mm_ctxts);</span><br><span> </span><br><span>        return ctx;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+out:</span><br><span style="color: hsl(120, 100%, 40%);">+   if (ctx->iu.mm_state_fsm)</span><br><span style="color: hsl(120, 100%, 40%);">+          osmo_fsm_inst_free(ctx->iu.mm_state_fsm);</span><br><span style="color: hsl(120, 100%, 40%);">+  if (ctx->gb.mm_state_fsm)</span><br><span style="color: hsl(120, 100%, 40%);">+          osmo_fsm_inst_free(ctx->gb.mm_state_fsm);</span><br><span style="color: hsl(120, 100%, 40%);">+  if (ctx->gmm_att_req.fsm)</span><br><span style="color: hsl(120, 100%, 40%);">+          osmo_fsm_inst_free(ctx->gmm_att_req.fsm);</span><br><span style="color: hsl(120, 100%, 40%);">+  if (ctx->gmm_fsm)</span><br><span style="color: hsl(120, 100%, 40%);">+          osmo_fsm_inst_free(ctx->gmm_fsm);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+        rate_ctr_group_free(ctx->ctrg);</span><br><span style="color: hsl(120, 100%, 40%);">+    talloc_free(ctx);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   return NULL;</span><br><span> }</span><br><span> /* Allocate a new SGSN MM context for GERAN_Gb */</span><br><span> struct sgsn_mm_ctx *sgsn_mm_ctx_alloc_gb(uint32_t tlli,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15704">change 15704</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15704"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I867612a60236eaf7009400c92f5d871006aaf008 </div>
<div style="display:none"> Gerrit-Change-Number: 15704 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>