<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/15686">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pcu_l1_if.cpp: Replace value 23 with libosmocore's GSM_MACBLOCK_LEN<br><br>Change-Id: Ieec3dd028fffa1a735afaaf3f93da0a1202d122a<br>---<br>M src/pcu_l1_if.cpp<br>1 file changed, 6 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/86/15686/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp</span><br><span>index 4d37afa..30e4524 100644</span><br><span>--- a/src/pcu_l1_if.cpp</span><br><span>+++ b/src/pcu_l1_if.cpp</span><br><span>@@ -208,16 +208,16 @@</span><br><span> void pcu_l1if_tx_agch(bitvec * block, int plen)</span><br><span> {</span><br><span>        struct gprs_rlcmac_bts *bts = bts_main_data();</span><br><span style="color: hsl(0, 100%, 40%);">-  uint8_t data[23]; /* prefix PLEN */</span><br><span style="color: hsl(0, 100%, 40%);">-     </span><br><span style="color: hsl(120, 100%, 40%);">+      uint8_t data[GSM_MACBLOCK_LEN]; /* prefix PLEN */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  /* FIXME: why does OpenBTS has no PLEN and no fill in message? */</span><br><span>    bitvec_pack(block, data + 1);</span><br><span>        data[0] = (plen << 2) | 0x01;</span><br><span> </span><br><span>      if (bts->gsmtap_categ_mask & (1 << PCU_GSMTAP_C_DL_AGCH))</span><br><span style="color: hsl(0, 100%, 40%);">-          gsmtap_send(bts->gsmtap, 0, 0, GSMTAP_CHANNEL_AGCH, 0, 0, 0, 0, data, 23);</span><br><span style="color: hsl(120, 100%, 40%);">+         gsmtap_send(bts->gsmtap, 0, 0, GSMTAP_CHANNEL_AGCH, 0, 0, 0, 0, data, GSM_MACBLOCK_LEN);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- pcu_tx_data_req(0, 0, PCU_IF_SAPI_AGCH, 0, 0, 0, data, 23);</span><br><span style="color: hsl(120, 100%, 40%);">+   pcu_tx_data_req(0, 0, PCU_IF_SAPI_AGCH, 0, 0, 0, data, GSM_MACBLOCK_LEN);</span><br><span> }</span><br><span> </span><br><span> #define PAGING_GROUP_LEN 3</span><br><span>@@ -379,8 +379,8 @@</span><br><span>       case PCU_IF_SAPI_PTCCH:</span><br><span>              /* FIXME */</span><br><span>          {</span><br><span style="color: hsl(0, 100%, 40%);">-                       struct msgb *msg = msgb_alloc(23, "l1_prim");</span><br><span style="color: hsl(0, 100%, 40%);">-                 memset(msgb_put(msg, 23), 0x2b, 23);</span><br><span style="color: hsl(120, 100%, 40%);">+                  struct msgb *msg = msgb_alloc(GSM_MACBLOCK_LEN, "l1_prim");</span><br><span style="color: hsl(120, 100%, 40%);">+                 memset(msgb_put(msg, GSM_MACBLOCK_LEN), 0x2b, GSM_MACBLOCK_LEN);</span><br><span>                     pcu_l1if_tx_ptcch(msg, rts_req->trx_nr, rts_req->ts_nr,</span><br><span>                                rts_req->arfcn, rts_req->fn, rts_req->block_nr);</span><br><span>            }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/15686">change 15686</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/15686"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ieec3dd028fffa1a735afaaf3f93da0a1202d122a </div>
<div style="display:none"> Gerrit-Change-Number: 15686 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>