<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15641">View Change</a></p><div style="white-space:pre-wrap">Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">MGCP_Test: test rtp directions separately in TC_ts101318_rfc5993_rtp_conversion<br><br>The testcase TC_ts101318_rfc5993_rtp_conversion tests the RTP packet<br>format conversion of ts101318 to rfc5993 and vice versa. At the moment<br>the testcase sends RTP packets in both directions at the same time. In<br>order to simplify the test and to make race conditions less likely, lets<br>test both directions separately and add some guard time.<br><br>Change-Id: Id9b69587f7fb5f6b0da072ac5f4863fd4111e597<br>---<br>M mgw/MGCP_Test.ttcn<br>1 file changed, 20 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn</span><br><span>index 1a45015..b46b178 100644</span><br><span>--- a/mgw/MGCP_Test.ttcn</span><br><span>+++ b/mgw/MGCP_Test.ttcn</span><br><span>@@ -1968,7 +1968,7 @@</span><br><span> f_vty_transceive(MGWVTY, "mgcp");</span><br><span> f_vty_transceive(MGWVTY, "rtp-patch rfc5993hr");</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* from us to MGW */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Connection #0 (Bidirectional) */</span><br><span> flow[0] := valueof(t_RtpFlow(mp_local_ip, mp_remote_ip, 111, "GSM-HR-08/8000"));</span><br><span> /* bind local RTP emulation sockets */</span><br><span> flow[0].em.portnr := 10000;</span><br><span>@@ -1978,7 +1978,7 @@</span><br><span> flow[0].rtp_cfg.tx_fixed_payload := '0b11b3eede60be4e3ec68838c7b5'O;</span><br><span> f_flow_create(RTPEM[0], ep, call_id, "sendrecv", flow[0]);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* from MGW back to us */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Connection #1 (Bidirectional) */</span><br><span> flow[1] := valueof(t_RtpFlow(mp_local_ip, mp_remote_ip, 111, "GSM-HR-08/8000"));</span><br><span> flow[1].em.portnr := 20000;</span><br><span> flow[1].rtp_cfg := c_RtpemDefaultCfg;</span><br><span>@@ -1987,17 +1987,31 @@</span><br><span> flow[1].rtp_cfg.tx_fixed_payload := '000b11b3eede60be4e3ec68838c7b5'O;</span><br><span> f_flow_create(RTPEM[1], ep, call_id, "sendrecv", flow[1]);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- f_rtpem_mode(RTPEM[1], RTPEM_MODE_BIDIR);</span><br><span style="color: hsl(0, 100%, 40%);">- f_rtpem_mode(RTPEM[0], RTPEM_MODE_BIDIR);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Send RTP packets to connection #0, receive on connection #1 */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rtpem_mode(RTPEM[1], RTPEM_MODE_RXONLY);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_sleep(0.5);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rtpem_mode(RTPEM[0], RTPEM_MODE_TXONLY);</span><br><span> f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rtpem_mode(RTPEM[0], RTPEM_MODE_NONE);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_sleep(0.5);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rtpem_mode(RTPEM[1], RTPEM_MODE_NONE);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* Send RTP packets to connection #1, receive on connection #0 */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rtpem_mode(RTPEM[0], RTPEM_MODE_RXONLY);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_sleep(0.5);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rtpem_mode(RTPEM[1], RTPEM_MODE_TXONLY);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_sleep(1.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rtpem_mode(RTPEM[1], RTPEM_MODE_NONE);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_sleep(0.5);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_rtpem_mode(RTPEM[0], RTPEM_MODE_NONE);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Remove RTP flows and check statistics */</span><br><span> f_flow_delete(RTPEM[0]);</span><br><span> f_flow_delete(RTPEM[1], ep, call_id);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* Check for errors */</span><br><span> stats[0] := f_rtpem_stats_get(RTPEM[0]);</span><br><span> stats[1] := f_rtpem_stats_get(RTPEM[1]);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> f_rtpem_stats_err_check(stats[0]);</span><br><span> f_rtpem_stats_err_check(stats[1]);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15641">change 15641</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15641"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id9b69587f7fb5f6b0da072ac5f4863fd4111e597 </div>
<div style="display:none"> Gerrit-Change-Number: 15641 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>