<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15646">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ccid: Fix overflow in Fi value<br><br>The Fi value can easily exceed 8bits. Even its default of 372 already<br>exceeds 256...<br><br>Change-Id: If2e2c46411d724883dca48f24e08d002e6670299<br>---<br>M ccid/ccid_device.h<br>M ccid/ccid_slot_sim.c<br>2 files changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ccid/ccid_device.h b/ccid/ccid_device.h</span><br><span>index d9cba52..afd4a7a 100644</span><br><span>--- a/ccid/ccid_device.h</span><br><span>+++ b/ccid/ccid_device.h</span><br><span>@@ -19,8 +19,8 @@</span><br><span> </span><br><span> struct ccid_pars_decoded {</span><br><span>     /* global for T0/T1 */</span><br><span style="color: hsl(0, 100%, 40%);">-  uint8_t fi;</span><br><span style="color: hsl(0, 100%, 40%);">-     uint8_t di;</span><br><span style="color: hsl(120, 100%, 40%);">+   uint32_t fi;</span><br><span style="color: hsl(120, 100%, 40%);">+  uint32_t di;</span><br><span>         enum ccid_clock_stop clock_stop;</span><br><span>     bool inverse_convention;</span><br><span> </span><br><span>diff --git a/ccid/ccid_slot_sim.c b/ccid/ccid_slot_sim.c</span><br><span>index 7bd1dba..1bd514a 100644</span><br><span>--- a/ccid/ccid_slot_sim.c</span><br><span>+++ b/ccid/ccid_slot_sim.c</span><br><span>@@ -32,8 +32,8 @@</span><br><span>                0x07, 0x18, 0x00, 0x00, 0x01, 0xA5 };</span><br><span> </span><br><span> static const struct ccid_pars_decoded slotsim_def_pars = {</span><br><span style="color: hsl(0, 100%, 40%);">- .fi = 0,</span><br><span style="color: hsl(0, 100%, 40%);">-        .di = 0,</span><br><span style="color: hsl(120, 100%, 40%);">+      .fi = 372,</span><br><span style="color: hsl(120, 100%, 40%);">+    .di = 1,</span><br><span>     .clock_stop = CCID_CLOCK_STOP_NOTALLOWED,</span><br><span>    .inverse_convention = false,</span><br><span>         .t0 = {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15646">change 15646</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/15646"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ccid-firmware </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If2e2c46411d724883dca48f24e08d002e6670299 </div>
<div style="display:none"> Gerrit-Change-Number: 15646 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>