<p>tsaitgaist has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/15647">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">hw: put board specific pin definition in corresponding file<br><br>SIM_PWEN and VCC_FWD are signals specific to the simtrace boards.<br>the corresponding pins PA5 and PA26 are used for other signal<br>on the octsim-tester.<br><br>Change-Id: I51f37dd112cf681f4b1dbb3d2320ff9a697eaa08<br>---<br>M firmware/libboard/common/include/board_common.h<br>M firmware/libboard/simtrace/include/board.h<br>2 files changed, 3 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/47/15647/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/firmware/libboard/common/include/board_common.h b/firmware/libboard/common/include/board_common.h</span><br><span>index cb72d40..ded4762 100644</span><br><span>--- a/firmware/libboard/common/include/board_common.h</span><br><span>+++ b/firmware/libboard/common/include/board_common.h</span><br><span>@@ -112,9 +112,6 @@</span><br><span> /* Interrupt request ID of USART peripheral connected to the phone */</span><br><span> #define IRQ_USART_PHONE USART1_IRQn</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#define SIM_PWEN        PIO_PA5</span><br><span style="color: hsl(0, 100%, 40%);">-#define VCC_FWD         PIO_PA26</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> // Board has UDP controller</span><br><span> #define BOARD_USB_UDP</span><br><span> </span><br><span>diff --git a/firmware/libboard/simtrace/include/board.h b/firmware/libboard/simtrace/include/board.h</span><br><span>index 0c1e533..7703451 100644</span><br><span>--- a/firmware/libboard/simtrace/include/board.h</span><br><span>+++ b/firmware/libboard/simtrace/include/board.h</span><br><span>@@ -35,7 +35,7 @@</span><br><span> /* Button to force bootloader start (shorted to ground when pressed */</span><br><span> #define PIN_BOOTLOADER_SW      {PIO_PA31, PIOA, ID_PIOA, PIO_INPUT, PIO_PULLUP}</span><br><span> /* Enable powering the card using the second 3.3 V output of the LDO (active high) */</span><br><span style="color: hsl(0, 100%, 40%);">-#define SIM_PWEN_PIN           {SIM_PWEN, PIOA, ID_PIOA, PIO_OUTPUT_1, PIO_DEFAULT}</span><br><span style="color: hsl(120, 100%, 40%);">+#define SIM_PWEN_PIN           {PIO_PA5, PIOA, ID_PIOA, PIO_OUTPUT_1, PIO_DEFAULT}</span><br><span> /* Enable powering the SIM card */</span><br><span> #define PWR_PINS                SIM_PWEN_PIN</span><br><span> /* Card presence pin */</span><br><span>@@ -93,9 +93,9 @@</span><br><span> /* Pins used to sniff phone-card communication */</span><br><span> #define PINS_SIM_SNIFF          PIN_SIM_IO, PIN_SIM_CLK, PIN_SIM_RST_SNIFF</span><br><span> /* Disable power converter 4.5-6V to 3.3V (active high) */</span><br><span style="color: hsl(0, 100%, 40%);">-#define PIN_SIM_PWEN_SNIFF     {SIM_PWEN, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT}</span><br><span style="color: hsl(120, 100%, 40%);">+#define PIN_SIM_PWEN_SNIFF     {PIO_PA5, PIOA, ID_PIOA, PIO_OUTPUT_0, PIO_DEFAULT}</span><br><span> /* Enable power switch to forward VCC_PHONE to VCC_SIM (active high) */</span><br><span style="color: hsl(0, 100%, 40%);">-#define PIN_VCC_FWD_SNIFF      {VCC_FWD, PIOA, ID_PIOA, PIO_OUTPUT_1, PIO_DEFAULT}</span><br><span style="color: hsl(120, 100%, 40%);">+#define PIN_VCC_FWD_SNIFF      {PIO_PA26, PIOA, ID_PIOA, PIO_OUTPUT_1, PIO_DEFAULT}</span><br><span> /* Use phone VCC to power card */</span><br><span> #define PINS_PWR_SNIFF          PIN_SIM_PWEN_SNIFF, PIN_VCC_FWD_SNIFF</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/15647">change 15647</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/15647"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I51f37dd112cf681f4b1dbb3d2320ff9a697eaa08 </div>
<div style="display:none"> Gerrit-Change-Number: 15647 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: tsaitgaist <kredon@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>