<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/15627">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bts-trx: vty: Print phy link state in cmd 'show transceiver'<br><br>Change-Id: I8e49f8edad9f9c68d110dbb7faeea5143aa91022<br>---<br>M include/osmo-bts/phy_link.h<br>M src/common/phy_link.c<br>M src/osmo-bts-trx/trx_vty.c<br>3 files changed, 16 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/27/15627/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmo-bts/phy_link.h b/include/osmo-bts/phy_link.h</span><br><span>index 3bf5159..a06cf3f 100644</span><br><span>--- a/include/osmo-bts/phy_link.h</span><br><span>+++ b/include/osmo-bts/phy_link.h</span><br><span>@@ -157,6 +157,8 @@</span><br><span> struct phy_link *phy_link_create(void *ctx, int num);</span><br><span> void phy_link_destroy(struct phy_link *plink);</span><br><span> void phy_link_state_set(struct phy_link *plink, enum phy_link_state state);</span><br><span style="color: hsl(120, 100%, 40%);">+enum phy_link_state phy_link_state_get(struct phy_link *plink);</span><br><span style="color: hsl(120, 100%, 40%);">+const char *phy_link_state_name(enum phy_link_state state);</span><br><span> int phy_links_open(void);</span><br><span> </span><br><span> struct phy_instance *phy_instance_by_num(struct phy_link *plink, int num);</span><br><span>diff --git a/src/common/phy_link.c b/src/common/phy_link.c</span><br><span>index 588fcc9..85f9e14 100644</span><br><span>--- a/src/common/phy_link.c</span><br><span>+++ b/src/common/phy_link.c</span><br><span>@@ -81,6 +81,16 @@</span><br><span>      plink->state = state;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+enum phy_link_state phy_link_state_get(struct phy_link *plink)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+  return plink->state;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+const char *phy_link_state_name(enum phy_link_state state)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+   return get_value_string(phy_link_state_vals, state);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> struct phy_instance *phy_instance_by_num(struct phy_link *plink, int num)</span><br><span> {</span><br><span>  struct phy_instance *pinst;</span><br><span>diff --git a/src/osmo-bts-trx/trx_vty.c b/src/osmo-bts-trx/trx_vty.c</span><br><span>index 250d180..f554ae5 100644</span><br><span>--- a/src/osmo-bts-trx/trx_vty.c</span><br><span>+++ b/src/osmo-bts-trx/trx_vty.c</span><br><span>@@ -66,13 +66,16 @@</span><br><span> </span><br><span>   llist_for_each_entry(trx, &bts->trx_list, list) {</span><br><span>             struct phy_instance *pinst = trx_phy_instance(trx);</span><br><span style="color: hsl(0, 100%, 40%);">-             char *sname = osmo_sock_get_name(NULL, pinst->phy_link->u.osmotrx.trx_ofd_clk.fd);</span><br><span style="color: hsl(120, 100%, 40%);">+              struct phy_link *plink = pinst->phy_link;</span><br><span style="color: hsl(120, 100%, 40%);">+          char *sname = osmo_sock_get_name(NULL, plink->u.osmotrx.trx_ofd_clk.fd);</span><br><span>          l1h = pinst->u.osmotrx.hdl;</span><br><span>               vty_out(vty, "TRX %d %s%s", trx->nr, sname, VTY_NEWLINE);</span><br><span>               talloc_free(sname);</span><br><span>          vty_out(vty, " %s%s",</span><br><span>                      trx_if_powered(l1h) ? "poweron":"poweroff",</span><br><span>                      VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+         vty_out(vty, "phy link state: %s%s",</span><br><span style="color: hsl(120, 100%, 40%);">+                        phy_link_state_name(phy_link_state_get(plink)), VTY_NEWLINE);</span><br><span>                if (l1h->config.arfcn_valid)</span><br><span>                      vty_out(vty, " arfcn  : %d%s%s",</span><br><span>                           (l1h->config.arfcn & ~ARFCN_PCS),</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/15627">change 15627</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/15627"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8e49f8edad9f9c68d110dbb7faeea5143aa91022 </div>
<div style="display:none"> Gerrit-Change-Number: 15627 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>