<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/15607">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">msgb: Allow size==headroom in msgb_alloc_headroom*()<br><br>Nothinh really forbids this case, it's totally fine allocating all space<br>of msgb as headroom. osmo-pcu actually does that in<br>gprs_rlcmac_ul_tbf::snd_ul_ud().<br><br>Related: OS#4029<br>Change-Id: Ibe05d08e3169a2603e891f76682a3b352a93ec7a<br>---<br>M include/osmocom/core/msgb.h<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/07/15607/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/core/msgb.h b/include/osmocom/core/msgb.h</span><br><span>index e05d37f..1833a6c 100644</span><br><span>--- a/include/osmocom/core/msgb.h</span><br><span>+++ b/include/osmocom/core/msgb.h</span><br><span>@@ -518,7 +518,7 @@</span><br><span> static inline struct msgb *msgb_alloc_headroom_c(const void *ctx, int size, int headroom,</span><br><span>                                                const char *name)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_static_assert(size > headroom, headroom_bigger);</span><br><span style="color: hsl(120, 100%, 40%);">+      osmo_static_assert(size >= headroom, headroom_bigger);</span><br><span> </span><br><span>        struct msgb *msg = msgb_alloc_c(ctx, size, name);</span><br><span>    if (msg)</span><br><span>@@ -540,7 +540,7 @@</span><br><span> static inline struct msgb *msgb_alloc_headroom(int size, int headroom,</span><br><span>                                             const char *name)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-  osmo_static_assert(size > headroom, headroom_bigger);</span><br><span style="color: hsl(120, 100%, 40%);">+      osmo_static_assert(size >= headroom, headroom_bigger);</span><br><span> </span><br><span>        struct msgb *msg = msgb_alloc(size, name);</span><br><span>   if (msg)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/15607">change 15607</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/15607"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ibe05d08e3169a2603e891f76682a3b352a93ec7a </div>
<div style="display:none"> Gerrit-Change-Number: 15607 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>