<p>neels <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/15544">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  neels: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">catch GSUP auth result without auth_fsm<br><br>When a vlr_subscr receives an Send Auth Info result, properly check whether the<br>subscriber has an auth_fsm.<br><br>Before, a missing auth_fsm would crash osmo-msc with:<br><br>    vlr.c:762 Trying to dispatch event 1 to non-existent FSM instance!<br><br>Related: OS#4191<br>Change-Id: I1995d8f68cfde1140968fb9a97bd054de950de2e<br>---<br>M src/libvlr/vlr.c<br>1 file changed, 6 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c</span><br><span>index a227240..80710b2 100644</span><br><span>--- a/src/libvlr/vlr.c</span><br><span>+++ b/src/libvlr/vlr.c</span><br><span>@@ -757,6 +757,12 @@</span><br><span>  struct osmo_fsm_inst *auth_fi = vsub->auth_fsm;</span><br><span>   void *data = (void *) gsup;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+       if (!auth_fi) {</span><br><span style="color: hsl(120, 100%, 40%);">+               LOGVSUBP(LOGL_ERROR, vsub, "Received GSUP %s, but there is no auth_fsm\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                   osmo_gsup_message_type_name(gsup->message_type));</span><br><span style="color: hsl(120, 100%, 40%);">+         return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+    }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  switch (gsup->message_type) {</span><br><span>     case OSMO_GSUP_MSGT_SEND_AUTH_INFO_RESULT:</span><br><span>           osmo_fsm_inst_dispatch(auth_fi, VLR_AUTH_E_HLR_SAI_ACK, data);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/15544">change 15544</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/15544"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1995d8f68cfde1140968fb9a97bd054de950de2e </div>
<div style="display:none"> Gerrit-Change-Number: 15544 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>