<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/15606">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tbf_dl: Setup m_llc_timer in constructor using osmocom API<br><br>Change-Id: I3e761b319326e33ab1d56c4fb30cafe3b0f96c29<br>---<br>M src/tbf_dl.cpp<br>1 file changed, 1 insertion(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/06/15606/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp</span><br><span>index fdd9ba3..23887d1 100644</span><br><span>--- a/src/tbf_dl.cpp</span><br><span>+++ b/src/tbf_dl.cpp</span><br><span>@@ -87,6 +87,7 @@</span><br><span>         m_dl_egprs_ctrs(NULL)</span><br><span> {</span><br><span>   memset(&m_llc_timer, 0, sizeof(m_llc_timer));</span><br><span style="color: hsl(120, 100%, 40%);">+     osmo_timer_setup(&m_llc_timer, llc_timer_cb, this);</span><br><span> }</span><br><span> </span><br><span> void gprs_rlcmac_dl_tbf::cleanup()</span><br><span>@@ -98,11 +99,6 @@</span><br><span> {</span><br><span>     if (bts_data()->llc_idle_ack_csec > 0) {</span><br><span>               struct timeval tv;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-              /* TODO: this ought to be within a constructor */</span><br><span style="color: hsl(0, 100%, 40%);">-               m_llc_timer.data = this;</span><br><span style="color: hsl(0, 100%, 40%);">-                m_llc_timer.cb = &llc_timer_cb;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>          csecs_to_timeval(bts_data()->llc_idle_ack_csec, &tv);</span><br><span>                 osmo_timer_schedule(&m_llc_timer, tv.tv_sec, tv.tv_usec);</span><br><span>        }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/15606">change 15606</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/15606"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3e761b319326e33ab1d56c4fb30cafe3b0f96c29 </div>
<div style="display:none"> Gerrit-Change-Number: 15606 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>