<p>pespin <strong>uploaded patch set #2</strong> to this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/15524">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">radioInterface: Atomically fetch and change underrun variable<br><br>Otherwise, it could happen that underrun events are lost:<br>TxLower (isUnderrun):     RxLower (pullBuffer):<br>read(underrun)<br>                 read(underrun)<br>                        write(underrun, |val) [maybe underrun becomes TRUE]<br>write(underrun, false)<br><br>Similary, it could happen the other direction if atomic was only applied<br>to isUnderrun:<br>TxLower (isUnderrun):  RxLower (pullBuffer):<br>                 read(underrun) -> true<br>read(underrun)-> true<br>write(underrun, false)<br>                   write(underrun, true|val) where val=false<br><br>So in here isUnderrun would return true twice while it should only<br>return one.<br><br>Change-Id: I684e0a5d2a9583a161d5a6593559b3a9e7cd57e3<br>---<br>M CommonLibs/Threads.cpp<br>M CommonLibs/Threads.h<br>M Transceiver52M/osmo-trx.cpp<br>M Transceiver52M/radioInterface.cpp<br>M Transceiver52M/radioInterface.h<br>M Transceiver52M/radioInterfaceMulti.cpp<br>M Transceiver52M/radioInterfaceResamp.cpp<br>M configure.ac<br>8 files changed, 61 insertions(+), 19 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/24/15524/2</pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/15524">change 15524</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/15524"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I684e0a5d2a9583a161d5a6593559b3a9e7cd57e3 </div>
<div style="display:none"> Gerrit-Change-Number: 15524 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: tnt <tnt@246tNt.com> </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>