<p>pespin <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/15522">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">UHDDevice: Drop unneeded MULTI_ARFCN checks<br><br>After previous changes, radioInterfaceMulti is expected to handle channel<br>conversion correctly, so it will always use chan 0 for all these<br>functions. This simplifies code in radioDevice avoiding need to add<br>checks to all devices supporting multi-arfcn in the future.<br><br>Change-Id: Ib2cd50a6ceaeedc6aaf3e1bb51d33b52911b6eba<br>---<br>M Transceiver52M/device/uhd/UHDDevice.cpp<br>1 file changed, 0 insertions(+), 12 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/device/uhd/UHDDevice.cpp b/Transceiver52M/device/uhd/UHDDevice.cpp</span><br><span>index 3b59291..809bade 100644</span><br><span>--- a/Transceiver52M/device/uhd/UHDDevice.cpp</span><br><span>+++ b/Transceiver52M/device/uhd/UHDDevice.cpp</span><br><span>@@ -247,9 +247,6 @@</span><br><span> </span><br><span> double uhd_device::setTxGain(double db, size_t chan)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- if (iface == MULTI_ARFCN)</span><br><span style="color: hsl(0, 100%, 40%);">-               chan = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>    if (chan >= tx_gains.size()) {</span><br><span>            LOGC(DDEV, ALERT) << "Requested non-existent channel" << chan;</span><br><span>                 return 0.0f;</span><br><span>@@ -281,9 +278,6 @@</span><br><span> </span><br><span> double uhd_device::setRxGain(double db, size_t chan)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-     if (iface == MULTI_ARFCN)</span><br><span style="color: hsl(0, 100%, 40%);">-               chan = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>    if (chan >= rx_gains.size()) {</span><br><span>            LOGC(DDEV, ALERT) << "Requested non-existent channel " << chan;</span><br><span>                return 0.0f;</span><br><span>@@ -299,9 +293,6 @@</span><br><span> </span><br><span> double uhd_device::getRxGain(size_t chan)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-        if (iface == MULTI_ARFCN)</span><br><span style="color: hsl(0, 100%, 40%);">-               chan = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>    if (chan >= rx_gains.size()) {</span><br><span>            LOGC(DDEV, ALERT) << "Requested non-existent channel " << chan;</span><br><span>                return 0.0f;</span><br><span>@@ -312,9 +303,6 @@</span><br><span> </span><br><span> double uhd_device::getTxGain(size_t chan)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-        if (iface == MULTI_ARFCN)</span><br><span style="color: hsl(0, 100%, 40%);">-               chan = 0;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>    if (chan >= tx_gains.size()) {</span><br><span>            LOGC(DDEV, ALERT) << "Requested non-existent channel " << chan;</span><br><span>                return 0.0f;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/15522">change 15522</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/15522"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib2cd50a6ceaeedc6aaf3e1bb51d33b52911b6eba </div>
<div style="display:none"> Gerrit-Change-Number: 15522 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>