<p>neels <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15570">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  neels: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Revert "MGCP: fix pattern warning"<br><br>For me this change causes MGCP parsing errors:<br><br>    setverdict(fail): pass -> fail reason: "Could not extract parameters for code "C""<br><br>Apparently the \r is after all necessary to parse MGCP. Maybe the '\r' is<br>implicit when an '\n' occurs, but the non-SDP part of MGCP has *only* '\r' line<br>breaks.<br><br>This reverts commit a9a52fff15227710e1a3a2e6222a388a3da11168.<br><br>Change-Id: I81d105b951590310c67f14f0b5d0c2777e206c5e<br>---<br>M library/MGCP_Types.ttcn<br>1 file changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/MGCP_Types.ttcn b/library/MGCP_Types.ttcn</span><br><span>index 6febc51..b56734c 100644</span><br><span>--- a/library/MGCP_Types.ttcn</span><br><span>+++ b/library/MGCP_Types.ttcn</span><br><span>@@ -54,7 +54,7 @@</span><br><span>               MgcpVersion     ver</span><br><span>  } with {</span><br><span>             variant "SEPARATOR(' ', '[\t ]+')"</span><br><span style="color: hsl(0, 100%, 40%);">-            variant "END('\n', '([\n])|(\n)')"</span><br><span style="color: hsl(120, 100%, 40%);">+          variant "END('\r\n', '([\r\n])|(\r\n)')"</span><br><span>   }</span><br><span> </span><br><span>        type record MgcpParameter {</span><br><span>@@ -63,7 +63,7 @@</span><br><span>      } with {</span><br><span>             variant "BEGIN('')"</span><br><span>                variant "SEPARATOR(': ', ':[\t ]+')"</span><br><span style="color: hsl(0, 100%, 40%);">-          variant "END('\n', '([\n])|(\n)')"</span><br><span style="color: hsl(120, 100%, 40%);">+          variant "END('\r\n', '([\r\n])|(\r\n)')"</span><br><span>   }</span><br><span> </span><br><span>        type set of MgcpParameter MgcpParameterList with {</span><br><span>@@ -76,7 +76,7 @@</span><br><span>               SDP_Message             sdp optional</span><br><span>         } with {</span><br><span>             variant "BEGIN('')"</span><br><span style="color: hsl(0, 100%, 40%);">-           variant (sdp) "BEGIN('\n','([\n])|(\n)')"</span><br><span style="color: hsl(120, 100%, 40%);">+           variant (sdp) "BEGIN('\r\n','([\r\n])|(\r\n)')"</span><br><span>    }</span><br><span> </span><br><span>        external function enc_MgcpCommand(in MgcpCommand id) return charstring</span><br><span>@@ -90,7 +90,7 @@</span><br><span>           charstring              string optional</span><br><span>      } with {</span><br><span>             variant "SEPARATOR(' ', '[\t ]+')"</span><br><span style="color: hsl(0, 100%, 40%);">-            variant "END('\n', '([\n])|(\n)')"</span><br><span style="color: hsl(120, 100%, 40%);">+          variant "END('\r\n', '([\r\n])|(\r\n)')"</span><br><span>   }</span><br><span> </span><br><span>        type record MgcpResponse {</span><br><span>@@ -99,7 +99,7 @@</span><br><span>               SDP_Message             sdp optional</span><br><span>         } with {</span><br><span>             variant "BEGIN('')"</span><br><span style="color: hsl(0, 100%, 40%);">-           variant (sdp) "BEGIN('\n','([\n])|(\n)')"</span><br><span style="color: hsl(120, 100%, 40%);">+           variant (sdp) "BEGIN('\r\n','([\r\n])|(\r\n)')"</span><br><span>    }</span><br><span> </span><br><span>        external function enc_MgcpResponse(in MgcpResponse id) return charstring</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15570">change 15570</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15570"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I81d105b951590310c67f14f0b5d0c2777e206c5e </div>
<div style="display:none"> Gerrit-Change-Number: 15570 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>