<p>pespin <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/15516">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">USRPDevice: Fix setRxGain return on error and getRxGain() returning always 0<br><br>field rxGain is set to 0 during constructor and never set after that<br>point.<br><br>Change-Id: I7fae7a315e5ab98a15c27628a88a92226ef89469<br>---<br>M Transceiver52M/device/usrp1/USRPDevice.cpp<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/device/usrp1/USRPDevice.cpp b/Transceiver52M/device/usrp1/USRPDevice.cpp</span><br><span>index 63debee..ef3f92a 100644</span><br><span>--- a/Transceiver52M/device/usrp1/USRPDevice.cpp</span><br><span>+++ b/Transceiver52M/device/usrp1/USRPDevice.cpp</span><br><span>@@ -305,10 +305,11 @@</span><br><span> </span><br><span>   if (!m_dbRx->set_gain(dB))</span><br><span>     LOGC(DDEV, ERR) << "Error setting RX gain";</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(120, 100%, 40%);">+  else</span><br><span style="color: hsl(120, 100%, 40%);">+    rxGain = dB;</span><br><span>   writeLock.unlock();</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  return dB;</span><br><span style="color: hsl(120, 100%, 40%);">+  return rxGain;</span><br><span> }</span><br><span> </span><br><span> bool USRPDevice::setRxAntenna(const std::string &ant, size_t chan)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/15516">change 15516</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/15516"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7fae7a315e5ab98a15c27628a88a92226ef89469 </div>
<div style="display:none"> Gerrit-Change-Number: 15516 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>