<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/15489">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo-bts-trx/scheduler: fix: check rc of osmo_ecu_frame_out()<br><br>Change-Id: I32d244f5ddef46c8b8719f5ec27b7456514d407a<br>Fixes: CID#204005 (CID#204007), CID#204006 (CID#204004)<br>---<br>M src/osmo-bts-trx/scheduler_trx.c<br>1 file changed, 10 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/89/15489/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c</span><br><span>index 45fc701..6107d2f 100644</span><br><span>--- a/src/osmo-bts-trx/scheduler_trx.c</span><br><span>+++ b/src/osmo-bts-trx/scheduler_trx.c</span><br><span>@@ -1272,6 +1272,11 @@</span><br><span>                   /* If there is an ECU active on this channel, use its output */</span><br><span>                      if (lchan->ecu_state) {</span><br><span>                           rc = osmo_ecu_frame_out(lchan->ecu_state, tch_data);</span><br><span style="color: hsl(120, 100%, 40%);">+                               if (rc < 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+                                      LOGL1S(DL1P, LOGL_ERROR, l1t, bi->tn, chan, bi->fn,</span><br><span style="color: hsl(120, 100%, 40%);">+                                            "ECU failed to encode a frame (rc=%d)\n", rc);</span><br><span style="color: hsl(120, 100%, 40%);">+                                       return rc;</span><br><span style="color: hsl(120, 100%, 40%);">+                            }</span><br><span>                            goto compose_l1sap;</span><br><span>                  }</span><br><span> </span><br><span>@@ -1485,6 +1490,11 @@</span><br><span>                       /* If there is an ECU active on this channel, use its output */</span><br><span>                      if (lchan->ecu_state) {</span><br><span>                           rc = osmo_ecu_frame_out(lchan->ecu_state, tch_data);</span><br><span style="color: hsl(120, 100%, 40%);">+                               if (rc < 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+                                      LOGL1S(DL1P, LOGL_ERROR, l1t, bi->tn, chan, bi->fn,</span><br><span style="color: hsl(120, 100%, 40%);">+                                            "ECU failed to encode a frame (rc=%d)\n", rc);</span><br><span style="color: hsl(120, 100%, 40%);">+                                       return rc;</span><br><span style="color: hsl(120, 100%, 40%);">+                            }</span><br><span>                            goto compose_l1sap;</span><br><span>                  }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/15489">change 15489</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/15489"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I32d244f5ddef46c8b8719f5ec27b7456514d407a </div>
<div style="display:none"> Gerrit-Change-Number: 15489 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>