<p>gnutoo has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/15503">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">python3 conversion: Use python 2 and 3 compatible exceptions<br><br>Without that we have:<br>  $ python3 pySim-read.py<br>  Using serial reader (port=/dev/ttyUSB0, baudrate=9600) interface<br>  Traceback (most recent call last):<br>    File "pySim-read.py", line 91, in <module><br>      from pySim.transport.serial import SerialSimLink<br>    File "/home/gnutoo/work/projects/osmocom/pysim/pySim/transport/serial.py", line 29, in <module><br>      from pySim.exceptions import NoCardError, ProtocolError<br>    File "/home/gnutoo/work/projects/osmocom/pysim/pySim/exceptions.py", line 26, in <module><br>      import exceptions<br>  ModuleNotFoundError: No module named 'exceptions'<br><br>Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org><br>Change-Id: Ie45dc7ccd72fe077ba3b424f221ff4ed02db436c<br>---<br>M pySim/exceptions.py<br>1 file changed, 8 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/03/15503/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/exceptions.py b/pySim/exceptions.py</span><br><span>index 831b1c9..c57b89c 100644</span><br><span>--- a/pySim/exceptions.py</span><br><span>+++ b/pySim/exceptions.py</span><br><span>@@ -23,14 +23,17 @@</span><br><span> </span><br><span> from __future__ import absolute_import</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-import exceptions</span><br><span style="color: hsl(120, 100%, 40%);">+try:</span><br><span style="color: hsl(120, 100%, 40%);">+        # This if for compatibility with python 2 and 3</span><br><span style="color: hsl(120, 100%, 40%);">+        from exceptions import Exception</span><br><span style="color: hsl(120, 100%, 40%);">+except:</span><br><span style="color: hsl(120, 100%, 40%);">+        pass</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-class NoCardError(exceptions.Exception):</span><br><span style="color: hsl(120, 100%, 40%);">+class NoCardError(Exception):</span><br><span>   pass</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-class ProtocolError(exceptions.Exception):</span><br><span style="color: hsl(120, 100%, 40%);">+class ProtocolError(Exception):</span><br><span>  pass</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-class ReaderError(exceptions.Exception):</span><br><span style="color: hsl(120, 100%, 40%);">+class ReaderError(Exception):</span><br><span>      pass</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/15503">change 15503</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/15503"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie45dc7ccd72fe077ba3b424f221ff4ed02db436c </div>
<div style="display:none"> Gerrit-Change-Number: 15503 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: gnutoo <GNUtoo@cyberdimension.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>