<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15488">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Revert "library/PCUIF_Types.ttcn: inform RAW codec about PADDING in PCUIF_data"<br><br>This reverts commit dd6d5d1baa62dc9d50fa90ef01fccb8a10284d53.<br><br>The PADDING seems to be a very experimental feature of TITAN. It works<br>very well for decoding of messages, so the padding bytes are getting<br>recognized as expected, but encoding is broken. Not only the data<br>buffer and its length are encoded in a wrong way, but other fields too.<br><br>Change-Id: Ieefa61232eb215a19a02e490255332e28e23b8f8<br>---<br>M library/PCUIF_Types.ttcn<br>1 file changed, 2 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/88/15488/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/PCUIF_Types.ttcn b/library/PCUIF_Types.ttcn</span><br><span>index 721eb64..27d9b92 100644</span><br><span>--- a/library/PCUIF_Types.ttcn</span><br><span>+++ b/library/PCUIF_Types.ttcn</span><br><span>@@ -77,15 +77,10 @@</span><br><span>       PCUIF_Text      text</span><br><span> } with { variant "" };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* This is a bad side of the current protocol design: fixed-size buffer is located</span><br><span style="color: hsl(0, 100%, 40%);">- * in between the other fields of the message, so if the payload is smaller than</span><br><span style="color: hsl(0, 100%, 40%);">- * 162 octets (1296 bits), we need to fill the remaining space with padding. */</span><br><span style="color: hsl(0, 100%, 40%);">-type octetstring PCUIF_DataPad with { variant "ALIGN(left), PADDING(1296)" };</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> type record PCUIF_data {</span><br><span>     PCUIF_Sapi      sapi,</span><br><span>        uint8_t         len,</span><br><span style="color: hsl(0, 100%, 40%);">-    PCUIF_DataPad   data,</span><br><span style="color: hsl(120, 100%, 40%);">+ octetstring     data length(162),</span><br><span>    uint32_t        fn,</span><br><span>  uint16_t        arfcn,</span><br><span>       uint8_t         trx_nr,</span><br><span>@@ -95,7 +90,7 @@</span><br><span>  uint16_t        ber10k,</span><br><span>      int16_t         ta_offs_qbits,</span><br><span>       int16_t         lqual_cb</span><br><span style="color: hsl(0, 100%, 40%);">-} with { variant (len) "LENGTHTO(data)" };</span><br><span style="color: hsl(120, 100%, 40%);">+} with { variant (data) "FIELDLENGTH(162), ALIGN(left)" };</span><br><span> </span><br><span> type record PCUIF_data_cnf_dt {</span><br><span>    PCUIF_Sapi      sapi,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15488">change 15488</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15488"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ieefa61232eb215a19a02e490255332e28e23b8f8 </div>
<div style="display:none"> Gerrit-Change-Number: 15488 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>