<p>pespin <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/15460">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bts-trx: Log case where no SETFORMAT is sent<br><br>If VTY cmd "osmotrx trxd-max-version 0" is used, max version 0 is used<br>(default starting one) and hence no need to send SETFORMAT (this is<br>useful in order to avoid sending SETFORMAT to old TRX implementations<br>not supporting the command). In this case, let's inform the user that<br>indeed osmo-bts won't send SETFORMAT because version 0 is assumed.<br><br>Change-Id: I7136ea6745c2275278bc400676b58fb4b10da966<br>---<br>M src/osmo-bts-trx/l1_if.c<br>1 file changed, 12 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-trx/l1_if.c b/src/osmo-bts-trx/l1_if.c</span><br><span>index db53d4c..cd2a03c 100644</span><br><span>--- a/src/osmo-bts-trx/l1_if.c</span><br><span>+++ b/src/osmo-bts-trx/l1_if.c</span><br><span>@@ -186,7 +186,8 @@</span><br><span> int l1if_provision_transceiver_trx(struct trx_l1h *l1h)</span><br><span> {</span><br><span>       uint8_t tn;</span><br><span style="color: hsl(0, 100%, 40%);">-     struct phy_link *plink = l1h->phy_inst->phy_link;</span><br><span style="color: hsl(120, 100%, 40%);">+       struct phy_instance *pinst = l1h->phy_inst;</span><br><span style="color: hsl(120, 100%, 40%);">+        struct phy_link *plink = pinst->phy_link;</span><br><span> </span><br><span>     if (!transceiver_available)</span><br><span>          return -EIO;</span><br><span>@@ -211,10 +212,16 @@</span><br><span>                 }</span><br><span> </span><br><span>                /* Ask transceiver to use the newest TRXD header version if not using it yet */</span><br><span style="color: hsl(0, 100%, 40%);">-         if (!l1h->config.setformat_sent &&</span><br><span style="color: hsl(0, 100%, 40%);">-               l1h->config.trxd_hdr_ver_use != plink->u.osmotrx.trxd_hdr_ver_max) {</span><br><span style="color: hsl(0, 100%, 40%);">-                  trx_if_cmd_setformat(l1h, plink->u.osmotrx.trxd_hdr_ver_max);</span><br><span style="color: hsl(0, 100%, 40%);">-                        l1h->config.trxd_hdr_ver_req = plink->u.osmotrx.trxd_hdr_ver_max;</span><br><span style="color: hsl(120, 100%, 40%);">+               if (!l1h->config.setformat_sent) {</span><br><span style="color: hsl(120, 100%, 40%);">+                 if (l1h->config.trxd_hdr_ver_use != plink->u.osmotrx.trxd_hdr_ver_max) {</span><br><span style="color: hsl(120, 100%, 40%);">+                                trx_if_cmd_setformat(l1h, plink->u.osmotrx.trxd_hdr_ver_max);</span><br><span style="color: hsl(120, 100%, 40%);">+                              l1h->config.trxd_hdr_ver_req = plink->u.osmotrx.trxd_hdr_ver_max;</span><br><span style="color: hsl(120, 100%, 40%);">+                       } else {</span><br><span style="color: hsl(120, 100%, 40%);">+                              LOGPPHI(pinst, DL1C, LOGL_INFO,</span><br><span style="color: hsl(120, 100%, 40%);">+                                       "No need to negotiate TRXD version, "</span><br><span style="color: hsl(120, 100%, 40%);">+                                       "already using maximum configured one: %" PRIu8 "\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                                     l1h->config.trxd_hdr_ver_use);</span><br><span style="color: hsl(120, 100%, 40%);">+                     }</span><br><span>                    l1h->config.setformat_sent = 1;</span><br><span>           }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/15460">change 15460</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/15460"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7136ea6745c2275278bc400676b58fb4b10da966 </div>
<div style="display:none"> Gerrit-Change-Number: 15460 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>