<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15456">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">library/GSM_RR_Types.ttcn: fix: apply '2B'O padding to GsmRrMessage<br><br>For some reason TITAN starts padding not from the beginning of<br>record ImmediateAssignment, but from it's wrapper GsmRrMessage.<br>As a result, dec_GsmRrMessage() warns about undecoded octets:<br><br>  Data remained at the end of the stream after successful decoding '2B2B2B'O<br><br>Similarly enc_GsmRrMessage() generates a shorter payload. Let's<br>work this around by applying PADDING attribute to GsmRrMessage.<br><br>Change-Id: I5fe327383402956213c20a68b18b8a48381156b5<br>---<br>M library/GSM_RR_Types.ttcn<br>1 file changed, 5 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn</span><br><span>index 49ceae3..b090d25 100644</span><br><span>--- a/library/GSM_RR_Types.ttcn</span><br><span>+++ b/library/GSM_RR_Types.ttcn</span><br><span>@@ -590,8 +590,7 @@</span><br><span>                 /* TODO: starting time TLV */</span><br><span>                IaRestOctets                    rest_octets</span><br><span>  } with { variant (chan_desc) "PRESENCE(ded_or_tbf.tbf = false)"</span><br><span style="color: hsl(0, 100%, 40%);">-                variant (pkt_chan_desc) "PRESENCE(ded_or_tbf.tbf = true)"</span><br><span style="color: hsl(0, 100%, 40%);">-             variant "PADDING(168), PADDING_PATTERN('00101011'B)" };</span><br><span style="color: hsl(120, 100%, 40%);">+             variant (pkt_chan_desc) "PRESENCE(ded_or_tbf.tbf = true)" };</span><br><span> </span><br><span>  /* 9.1.20 */</span><br><span>         type record ReqRefWaitInd {</span><br><span>@@ -683,7 +682,10 @@</span><br><span>                           pag_req_2, header.message_type = PAGING_REQUEST_TYPE_2;</span><br><span>                              pag_req_3, header.message_type = PAGING_REQUEST_TYPE_3;</span><br><span>                            other, OTHERWISE;</span><br><span style="color: hsl(0, 100%, 40%);">-                 )" };</span><br><span style="color: hsl(120, 100%, 40%);">+                    )"</span><br><span style="color: hsl(120, 100%, 40%);">+                /* Total message length: 184 = 23 * 8. Pad spare bits with '2B'O. */</span><br><span style="color: hsl(120, 100%, 40%);">+          variant "PADDING(184), PADDING_PATTERN('00101011'B)"</span><br><span style="color: hsl(120, 100%, 40%);">+       };</span><br><span> </span><br><span>       external function enc_GsmRrMessage(in GsmRrMessage msg) return octetstring</span><br><span>           with { extension "prototype(convert) encode(RAW)" };</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15456">change 15456</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15456"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5fe327383402956213c20a68b18b8a48381156b5 </div>
<div style="display:none"> Gerrit-Change-Number: 15456 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>