<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15446">View Change</a></p><div style="white-space:pre-wrap">Approvals:
fixeria: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">library/GSM_RR_Types.ttcn: fix ImmediateAssignment coding regressions<br><br>Since I403d2141536303a966be7ff51b06c3de202412e6, IA Rest Octets is<br>a mandatory IE. When changing the definition of ts_IMM_ASS, I forgot<br>to mark its optional 'lh', 'hl', and 'hh' as omitted explicitly.<br><br>As a result, many of our TTCN-3 test cases were broken:<br><br> Dynamic test case error: Using an unbound optional field.<br><br>Also, in Ifdcdcf50709fcc03195cb8ef6092977e26f910ec I added an<br>optional field 'pad' to record 'IaRestOctets'. That was not the<br>best solution, because padding should be handled transparently.<br><br>Let's get rid of that dummy field and equip both 'ImmediateAssignment'<br>and 'IaRestOctets' records with proper padding attributes. The later<br>one needs to be marked with 'CSN.1 L/H' attribute in the future, but<br>for now we should keep it octet-aligned.<br><br>Change-Id: I69d5fbd8e3388e287bfa54f02454d207e62ee640<br>---<br>M library/GSM_RR_Types.ttcn<br>1 file changed, 6 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn</span><br><span>index f313e23..b098118 100644</span><br><span>--- a/library/GSM_RR_Types.ttcn</span><br><span>+++ b/library/GSM_RR_Types.ttcn</span><br><span>@@ -543,13 +543,13 @@</span><br><span> IaRestOctLL ll optional,</span><br><span> IaRestOctLH lh optional,</span><br><span> IaRestOctHL hl optional,</span><br><span style="color: hsl(0, 100%, 40%);">- IaRestOctHH hh optional,</span><br><span style="color: hsl(0, 100%, 40%);">- bitstring pad optional</span><br><span style="color: hsl(120, 100%, 40%);">+ IaRestOctHH hh optional</span><br><span> } with {</span><br><span> variant (ll) "PRESENCE(presence = '00'B)"</span><br><span> variant (lh) "PRESENCE(presence = '01'B)"</span><br><span> variant (hl) "PRESENCE(presence = '10'B)"</span><br><span> variant (hh) "PRESENCE(presence = '11'B)"</span><br><span style="color: hsl(120, 100%, 40%);">+ variant "PADDING(yes), PADDING_PATTERN('00101011'B)"</span><br><span> };</span><br><span> </span><br><span> type record MeasurementResults {</span><br><span>@@ -590,7 +590,8 @@</span><br><span> /* TODO: starting time TLV */</span><br><span> IaRestOctets rest_octets</span><br><span> } with { variant (chan_desc) "PRESENCE(ded_or_tbf.tbf = false)"</span><br><span style="color: hsl(0, 100%, 40%);">- variant (pkt_chan_desc) "PRESENCE(ded_or_tbf.tbf = true)" };</span><br><span style="color: hsl(120, 100%, 40%);">+ variant (pkt_chan_desc) "PRESENCE(ded_or_tbf.tbf = true)"</span><br><span style="color: hsl(120, 100%, 40%);">+ variant "PADDING(168), PADDING_PATTERN('00101011'B)" };</span><br><span> </span><br><span> /* 9.1.20 */</span><br><span> type record ReqRefWaitInd {</span><br><span>@@ -744,7 +745,8 @@</span><br><span> /* Compressed INTER RAT HO INFO: shall not be used (L)</span><br><span> * TODO: use variant "CSN.1 L/H" to avoid confusion. */</span><br><span> compressed_irat_ho_info_ind := '1'B</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ lh := omit, hl := omit, hh := omit</span><br><span> }</span><br><span> }</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15446">change 15446</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15446"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I69d5fbd8e3388e287bfa54f02454d207e62ee640 </div>
<div style="display:none"> Gerrit-Change-Number: 15446 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>