<p>osmith <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15401">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Revert "bts: f_init_pcu: sleep before connect"<br><br>This reverts commit c089b415f5e3bbf5eb2de435b925581ca42d8872. The<br>additional sleep caused other tests to break, probably because it<br>triggered race conditions:<br>* TC_pcu_socket_connect_multi<br>* TC_pcu_socket_connect_si3gprs<br>* TC_si_sched_13_2bis_2ter_2quater<br><br>Adjust TC_pcu_socket_verify_info_ind test case error message to mention<br>OS#4179. This test is flapping now, most of the time the BTS sends a<br>CellID 0 because it did not receive the real CellID from the BSC yet.<br><br>Related: OS#4179<br>Change-Id: I2115c337f4601a4614b140715323c42803b003ee<br>---<br>M bts/BTS_Tests.ttcn<br>1 file changed, 3 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn</span><br><span>index 15948a3..2c11ca2 100644</span><br><span>--- a/bts/BTS_Tests.ttcn</span><br><span>+++ b/bts/BTS_Tests.ttcn</span><br><span>@@ -324,9 +324,6 @@</span><br><span>           pcu_conn_id := -1;</span><br><span>           return;</span><br><span>      }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-       f_sleep(0.5); /* workaround for OS#4179 */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>   pcu_conn_id := f_pcuif_connect(pt, mp_pcu_socket);</span><br><span> </span><br><span>       T.start;</span><br><span>@@ -4876,7 +4873,9 @@</span><br><span>     var uint16_t cell_id_si3 := si3.payload.si3.cell_id;</span><br><span>         var uint16_t cell_id_pcu := g_pcu_last_info.u.info_ind.cell_id;</span><br><span>      if (cell_id_si3 != cell_id_pcu) {</span><br><span style="color: hsl(0, 100%, 40%);">-               setverdict(fail, "Expected cell_id ", cell_id_si3, " got: ", cell_id_pcu);</span><br><span style="color: hsl(120, 100%, 40%);">+                setverdict(fail, "Expected cell_id '", cell_id_si3, "' and got '", cell_id_pcu, "'. This either means,",</span><br><span style="color: hsl(120, 100%, 40%);">+                                 " that the BTS is sending the wrong cell_id, or that the BTS sent it too early",</span><br><span style="color: hsl(120, 100%, 40%);">+                            " (OS#4179)");</span><br><span>    }</span><br><span> </span><br><span>        /* Verify LAC */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15401">change 15401</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15401"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2115c337f4601a4614b140715323c42803b003ee </div>
<div style="display:none"> Gerrit-Change-Number: 15401 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>