<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/15433">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Transceiver: Fix logging TN and version<br><br>Since tn is declared as uint8_t, it's actually a char, and by default<br>c++'s ostream& operator<<(ostream&, unsigned char) tries to print chars<br>with its ASCII visible character instead of numeric value.<br><br>Change-Id: I534158e8e1719ad19a9cde7c747a8f8ad5a01a2b<br>---<br>M Transceiver52M/Transceiver.cpp<br>1 file changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/33/15433/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp</span><br><span>index 590101c..0583998 100644</span><br><span>--- a/Transceiver52M/Transceiver.cpp</span><br><span>+++ b/Transceiver52M/Transceiver.cpp</span><br><span>@@ -968,12 +968,12 @@</span><br><span>   case 1:</span><br><span>     break;</span><br><span>   default:</span><br><span style="color: hsl(0, 100%, 40%);">-    LOG(ERR) << "Rx TRXD message with unknown header version " << dl->common.version;</span><br><span style="color: hsl(120, 100%, 40%);">+    LOG(ERR) << "Rx TRXD message with unknown header version " << unsigned(dl->common.version);</span><br><span>     return false;</span><br><span>   }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  LOG(DEBUG) << "Rx TRXD message (hdr_ver=" << dl->common.version << "): "</span><br><span style="color: hsl(0, 100%, 40%);">-             << "fn=" << fn << ", tn=" << dl->common.tn << ", "</span><br><span style="color: hsl(120, 100%, 40%);">+  LOG(DEBUG) << "Rx TRXD message (hdr_ver=" << unsigned(dl->common.version) << "): "</span><br><span style="color: hsl(120, 100%, 40%);">+             << "fn=" << fn << ", tn=" << unsigned(dl->common.tn) << ", "</span><br><span>              << "burst_len=" << burstLen;</span><br><span> </span><br><span>   BitVector newBurst(burstLen);</span><br><span>@@ -1018,7 +1018,7 @@</span><br><span> </span><br><span>   LOG(DEBUG) << std::fixed << std::right</span><br><span>     << " chan: "   << chan</span><br><span style="color: hsl(0, 100%, 40%);">-    << " time: "   << bi->tn << ":" << bi->fn</span><br><span style="color: hsl(120, 100%, 40%);">+    << " time: "   << unsigned(bi->tn) << ":" << bi->fn</span><br><span>     << " RSSI: "   << std::setw(5) << std::setprecision(1) << (bi->rssi - rssiOffset)</span><br><span>                    << "dBFS/" << std::setw(6) << -bi->rssi << "dBm"</span><br><span>     << " noise: "  << std::setw(5) << std::setprecision(1) << (bi->noise - rssiOffset)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/15433">change 15433</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/15433"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I534158e8e1719ad19a9cde7c747a8f8ad5a01a2b </div>
<div style="display:none"> Gerrit-Change-Number: 15433 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>