<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/15405">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ss7: Do not queue messages if stream is not connected<br><br>Consider them as lost by the lower layer, otherwise lots of old messages<br>and retransmissions can end up queued in there until stream becomes<br>connected, and then will flood the peer with all those messages.<br><br>Depends: libosmo-netif.git 962bf9a48eed418354685dc733b8271d2dd62c27<br>Related: OS#4188<br>Change-Id: Ic7d3571848faf28221dcfa8eb8b33b42964d988e<br>---<br>M src/osmo_ss7.c<br>1 file changed, 5 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/05/15405/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c</span><br><span>index e8a6918..053feca 100644</span><br><span>--- a/src/osmo_ss7.c</span><br><span>+++ b/src/osmo_ss7.c</span><br><span>@@ -1810,6 +1810,11 @@</span><br><span>                      msgb_free(msg);</span><br><span>                      return -EIO;</span><br><span>                 }</span><br><span style="color: hsl(120, 100%, 40%);">+             if (!osmo_stream_cli_is_connected(asp->client)) {</span><br><span style="color: hsl(120, 100%, 40%);">+                  LOGPASP(asp, DLSS7, LOGL_ERROR, "Cannot transmit, asp->client not connected\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                 msgb_free(msg);</span><br><span style="color: hsl(120, 100%, 40%);">+                       return -EIO;</span><br><span style="color: hsl(120, 100%, 40%);">+          }</span><br><span>            osmo_stream_cli_send(asp->client, msg);</span><br><span>   }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/15405">change 15405</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-sccp/+/15405"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic7d3571848faf28221dcfa8eb8b33b42964d988e </div>
<div style="display:none"> Gerrit-Change-Number: 15405 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>