<p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15163">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/15163/2/sgsn/SGSN_Tests_Iu.ttcn">File sgsn/SGSN_Tests_Iu.ttcn:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/15163/2/sgsn/SGSN_Tests_Iu.ttcn@38">Patch Set #2, Line 38:</a> <code style="font-family:monospace,monospace">private function f_TC_iu_attach_geran_rau(charstring id) runs on BSSGP_ConnHdlr {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Would be great if you could describe what the test does in a comment on the line prior to the function definition:<br>/* First perform regular attach through RANAP, then RAU over GERAN */</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/15163/2/sgsn/SGSN_Tests_Iu.ttcn@41">Patch Set #2, Line 41:</a> <code style="font-family:monospace,monospace">     /* first perform regular attach */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">over RANAP/Iu</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/15163/2/sgsn/SGSN_Tests_Iu.ttcn@45">Patch Set #2, Line 45:</a> <code style="font-family:monospace,monospace">      f_routing_area_update(g_pars.ra);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">over GERAN?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15163">change 15163</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15163"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie043639638a640a2041324fc910964385a41c77d </div>
<div style="display:none"> Gerrit-Change-Number: 15163 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 03 Sep 2019 18:24:48 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>