<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15400">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sgsn: replace variable bssgp_index with gb_idx<br><br>gb_idx is common used as variable for the index of the bssgb array.<br>Be consistent and use the same variable name everywhere.<br><br>Change-Id: Iec2e8510b749602f0ebb9b4976957c9c5ce3f307<br>---<br>M sgsn/SGSN_Tests.ttcn<br>1 file changed, 10 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/00/15400/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn</span><br><span>index c486be1..0a8aef0 100644</span><br><span>--- a/sgsn/SGSN_Tests.ttcn</span><br><span>+++ b/sgsn/SGSN_Tests.ttcn</span><br><span>@@ -676,12 +676,12 @@</span><br><span>         deactivate(di);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-function f_upd_ptmsi_and_tlli(OCT4 p_tmsi, integer bssgp_index := 0) runs on BSSGP_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+function f_upd_ptmsi_and_tlli(OCT4 p_tmsi, integer gb_idx := 0) runs on BSSGP_ConnHdlr {</span><br><span>      g_pars.p_tmsi := p_tmsi;</span><br><span>     /* update TLLI */</span><br><span>    g_pars.tlli_old := g_pars.tlli;</span><br><span>      g_pars.tlli := g_pars.p_tmsi or4b 'c0000000'O;</span><br><span style="color: hsl(0, 100%, 40%);">-  f_bssgp_client_llgmm_assign(g_pars.tlli_old, g_pars.tlli, BSSGP_PROC[bssgp_index]);</span><br><span style="color: hsl(120, 100%, 40%);">+   f_bssgp_client_llgmm_assign(g_pars.tlli_old, g_pars.tlli, BSSGP_PROC[gb_idx]);</span><br><span> }</span><br><span> </span><br><span> function f_process_attach_accept(PDU_GMM_AttachAccept aa) runs on BSSGP_ConnHdlr {</span><br><span>@@ -713,7 +713,7 @@</span><br><span>  /* T3302, T3319, T3323, T3312_ext, T3324 */</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-function f_process_rau_accept(PDU_GMM_RoutingAreaUpdateAccept ra, integer bssgp_index := 0) runs on BSSGP_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+function f_process_rau_accept(PDU_GMM_RoutingAreaUpdateAccept ra, integer gb_idx := 0) runs on BSSGP_ConnHdlr {</span><br><span>    /* mandatory IE */</span><br><span>   g_pars.ra := ra.routingAreaId;</span><br><span>       if (ispresent(ra.allocatedPTMSI)) {</span><br><span>@@ -721,7 +721,7 @@</span><br><span>                    setverdict(fail, "unexpected P-TMSI allocation");</span><br><span>                  mtc.stop;</span><br><span>            }</span><br><span style="color: hsl(0, 100%, 40%);">-               f_upd_ptmsi_and_tlli(ra.allocatedPTMSI.mobileIdentityLV.mobileIdentityV.oddEvenInd_identity.tmsi_ptmsi.octets, bssgp_index);</span><br><span style="color: hsl(120, 100%, 40%);">+          f_upd_ptmsi_and_tlli(ra.allocatedPTMSI.mobileIdentityLV.mobileIdentityV.oddEvenInd_identity.tmsi_ptmsi.octets, gb_idx);</span><br><span>      }</span><br><span>    if (ispresent(ra.msIdentity)) {</span><br><span>              setverdict(fail, "unexpected TMSI allocation in non-combined attach");</span><br><span>@@ -1099,10 +1099,10 @@</span><br><span> }</span><br><span> </span><br><span> /* general GPRS DETACH helper */</span><br><span style="color: hsl(0, 100%, 40%);">-function f_detach_mo(BIT3 detach_type, boolean power_off, boolean expect_purge, integer bssgp_index := 0) runs on BSSGP_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+function f_detach_mo(BIT3 detach_type, boolean power_off, boolean expect_purge, integer gb_idx := 0) runs on BSSGP_ConnHdlr {</span><br><span>     var PDU_L3_SGSN_MS l3_mt;</span><br><span>    timer T := 5.0;</span><br><span style="color: hsl(0, 100%, 40%);">- f_send_l3(ts_GMM_DET_REQ_MO(detach_type, power_off), bssgp_index);</span><br><span style="color: hsl(120, 100%, 40%);">+    f_send_l3(ts_GMM_DET_REQ_MO(detach_type, power_off), gb_idx);</span><br><span>        if (expect_purge) {</span><br><span>          GSUP.receive(tr_GSUP_PURGE_MS_REQ(g_pars.imsi, OSMO_GSUP_CN_DOMAIN_PS));</span><br><span>             GSUP.send(ts_GSUP_PURGE_MS_RES(g_pars.imsi));</span><br><span>@@ -1113,7 +1113,7 @@</span><br><span>                setverdict(fail, "Unexpected GSUP PURGE MS for unregistered TLLI");</span><br><span>                mtc.stop;</span><br><span>            }</span><br><span style="color: hsl(0, 100%, 40%);">-       [power_off] BSSGP[bssgp_index].receive(tr_GMM_DET_ACCEPT_MT) -> value l3_mt {</span><br><span style="color: hsl(120, 100%, 40%);">+      [power_off] BSSGP[gb_idx].receive(tr_GMM_DET_ACCEPT_MT) -> value l3_mt {</span><br><span>          g_pars.ra := omit;</span><br><span>           setverdict(fail, "Unexpected DETACH ACCEPT in power-off DETACH");</span><br><span>          mtc.stop;</span><br><span>@@ -1122,12 +1122,12 @@</span><br><span>  [power_off] T.timeout {</span><br><span>              setverdict(pass);</span><br><span>            }</span><br><span style="color: hsl(0, 100%, 40%);">-       [not power_off] BSSGP[bssgp_index].receive(tr_GMM_DET_ACCEPT_MT) -> value l3_mt {</span><br><span style="color: hsl(120, 100%, 40%);">+  [not power_off] BSSGP[gb_idx].receive(tr_GMM_DET_ACCEPT_MT) -> value l3_mt {</span><br><span>              g_pars.ra := omit;</span><br><span>           setverdict(pass);</span><br><span>            /* TODO: check if any PDP contexts are deactivated on network side? */</span><br><span>               }</span><br><span style="color: hsl(0, 100%, 40%);">-       [] BSSGP[bssgp_index].receive(PDU_L3_SGSN_MS:?) -> value l3_mt {</span><br><span style="color: hsl(120, 100%, 40%);">+   [] BSSGP[gb_idx].receive(PDU_L3_SGSN_MS:?) -> value l3_mt {</span><br><span>               if (power_off) {</span><br><span>                     setverdict(fail, "Unexpected Layer 3 package received in power-off DETACH");</span><br><span>               } else {</span><br><span>@@ -1135,7 +1135,7 @@</span><br><span>             }</span><br><span>            mtc.stop;</span><br><span>            }</span><br><span style="color: hsl(0, 100%, 40%);">-       [] BSSGP[bssgp_index].receive { repeat; }</span><br><span style="color: hsl(120, 100%, 40%);">+     [] BSSGP[gb_idx].receive { repeat; }</span><br><span>         }</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15400">change 15400</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15400"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iec2e8510b749602f0ebb9b4976957c9c5ce3f307 </div>
<div style="display:none"> Gerrit-Change-Number: 15400 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>