<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15399">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sgsn: replace variable bssgp with gb_idx<br><br>gb_idx is common used as variable for the index of the bssgb array.<br>Be consistent and use the same variable name everywhere.<br><br>Change-Id: Ib278410bc49f07387873740ed8b411a815d940a8<br>---<br>M sgsn/SGSN_Tests.ttcn<br>M sgsn/SGSN_Tests_Iu.ttcn<br>2 files changed, 14 insertions(+), 14 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/99/15399/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn</span><br><span>index e4a5cbf..c486be1 100644</span><br><span>--- a/sgsn/SGSN_Tests.ttcn</span><br><span>+++ b/sgsn/SGSN_Tests.ttcn</span><br><span>@@ -2365,7 +2365,7 @@</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-friend function f_routing_area_update(RoutingAreaIdentificationV ra, integer bssgp := 0, boolean send_ptmsi := false) runs on BSSGP_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+friend function f_routing_area_update(RoutingAreaIdentificationV ra, integer gb_idx := 0, boolean send_ptmsi := false) runs on BSSGP_ConnHdlr {</span><br><span> var PDU_L3_SGSN_MS l3_mt;</span><br><span> var PDU_DTAP_PS_MT mt;</span><br><span> var template OCT4 p_tmsi := omit;</span><br><span>@@ -2375,29 +2375,29 @@</span><br><span> p_tmsi := g_pars.p_tmsi;</span><br><span> }</span><br><span> /* then send RAU */</span><br><span style="color: hsl(0, 100%, 40%);">- f_send_l3(ts_GMM_RAU_REQ(f_mi_get_lv(), GPRS_UPD_T_RA, g_pars.ra, false, omit, omit, p_tmsi), bssgp, initial := true);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_send_l3(ts_GMM_RAU_REQ(f_mi_get_lv(), GPRS_UPD_T_RA, g_pars.ra, false, omit, omit, p_tmsi), gb_idx, initial := true);</span><br><span> alt {</span><br><span style="color: hsl(0, 100%, 40%);">- [is_gb(bssgp)] BSSGP[bssgp].receive(tr_GMM_RAU_ACCEPT) -> value l3_mt {</span><br><span style="color: hsl(0, 100%, 40%);">- f_process_rau_accept(l3_mt.msgs.gprs_mm.routingAreaUpdateAccept, bssgp);</span><br><span style="color: hsl(0, 100%, 40%);">- f_send_l3(ts_GMM_RAU_COMPL, bssgp);</span><br><span style="color: hsl(120, 100%, 40%);">+ [is_gb(gb_idx)] BSSGP[gb_idx].receive(tr_GMM_RAU_ACCEPT) -> value l3_mt {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_process_rau_accept(l3_mt.msgs.gprs_mm.routingAreaUpdateAccept, gb_idx);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_send_l3(ts_GMM_RAU_COMPL, gb_idx);</span><br><span> setverdict(pass);</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- [is_iu(bssgp)] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_GMM_RAU_ACCEPT)) -> value mt {</span><br><span style="color: hsl(0, 100%, 40%);">- f_process_rau_accept(mt.dtap.msgs.gprs_mm.routingAreaUpdateAccept, bssgp);</span><br><span style="color: hsl(0, 100%, 40%);">- f_send_l3(ts_GMM_RAU_COMPL, bssgp);</span><br><span style="color: hsl(120, 100%, 40%);">+ [is_iu(gb_idx)] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_GMM_RAU_ACCEPT)) -> value mt {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_process_rau_accept(mt.dtap.msgs.gprs_mm.routingAreaUpdateAccept, gb_idx);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_send_l3(ts_GMM_RAU_COMPL, gb_idx);</span><br><span> setverdict(pass);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- [is_gb(bssgp)] BSSGP[bssgp].receive(tr_GMM_RAU_REJECT) {</span><br><span style="color: hsl(120, 100%, 40%);">+ [is_gb(gb_idx)] BSSGP[gb_idx].receive(tr_GMM_RAU_REJECT) {</span><br><span> setverdict(fail, "Unexpected RAU Reject");</span><br><span> mtc.stop;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- [is_iu(bssgp)] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_GMM_RAU_REJECT)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ [is_iu(gb_idx)] BSSAP.receive(tr_PDU_DTAP_PS_MT(tr_GMM_RAU_REJECT)) {</span><br><span> setverdict(fail, "Unexpected RAU Reject");</span><br><span> mtc.stop;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- [is_iu(bssgp)] BSSAP.receive(tr_RANAP_SecurityModeCmd(uia_algs := ?, uia_key := oct2bit(g_pars.vec.ik),</span><br><span style="color: hsl(120, 100%, 40%);">+ [is_iu(gb_idx)] BSSAP.receive(tr_RANAP_SecurityModeCmd(uia_algs := ?, uia_key := oct2bit(g_pars.vec.ik),</span><br><span> key_sts := ?)) {</span><br><span> var IntegrityProtectionAlgorithm uia_chosen := 0; /*standard_UMTS_integrity_algorithm_UIA1;*/</span><br><span> BSSAP.send(ts_RANAP_SecurityModeComplete(uia_chosen));</span><br><span>@@ -2405,8 +2405,8 @@</span><br><span> /* allow to common id to be received */</span><br><span> f_sleep(1.0);</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- [is_gb(bssgp)] BSSGP[bssgp].receive { repeat; }</span><br><span style="color: hsl(0, 100%, 40%);">- [is_iu(bssgp)] BSSAP.receive { repeat; }</span><br><span style="color: hsl(120, 100%, 40%);">+ [is_gb(gb_idx)] BSSGP[gb_idx].receive { repeat; }</span><br><span style="color: hsl(120, 100%, 40%);">+ [is_iu(gb_idx)] BSSAP.receive { repeat; }</span><br><span> }</span><br><span> </span><br><span> deactivate(commonid);</span><br><span>diff --git a/sgsn/SGSN_Tests_Iu.ttcn b/sgsn/SGSN_Tests_Iu.ttcn</span><br><span>index 50118c7..c0830ee 100644</span><br><span>--- a/sgsn/SGSN_Tests_Iu.ttcn</span><br><span>+++ b/sgsn/SGSN_Tests_Iu.ttcn</span><br><span>@@ -61,7 +61,7 @@</span><br><span> f_gmm_attach(umts_aka_challenge := true, force_gsm_sres := false, gb_idx := 0);</span><br><span> </span><br><span> /* do a routing area update */</span><br><span style="color: hsl(0, 100%, 40%);">- f_routing_area_update(g_pars.ra, bssgp := 3, send_ptmsi := true);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_routing_area_update(g_pars.ra, gb_idx := 3, send_ptmsi := true);</span><br><span> setverdict(pass);</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15399">change 15399</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15399"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib278410bc49f07387873740ed8b411a815d940a8 </div>
<div style="display:none"> Gerrit-Change-Number: 15399 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>