<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15307">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Introduce log helper LOGGGSN and log category DGTP<br><br>It will be used in forthcoming commits.<br><br>Change-Id: I30f46f44af1d0eee324b1a995c1dad2e1315af7c<br>---<br>M include/osmocom/sgsn/debug.h<br>M include/osmocom/sgsn/gprs_sgsn.h<br>M src/gprs/sgsn_main.c<br>3 files changed, 13 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/sgsn/debug.h b/include/osmocom/sgsn/debug.h</span><br><span>index 4d0fc69..29d500d 100644</span><br><span>--- a/include/osmocom/sgsn/debug.h</span><br><span>+++ b/include/osmocom/sgsn/debug.h</span><br><span>@@ -39,6 +39,7 @@</span><br><span>   DVLR,</span><br><span>        DIUCS,</span><br><span>       DSIGTRAN,</span><br><span style="color: hsl(120, 100%, 40%);">+     DGTP,</span><br><span>        Debug_LastEntry,</span><br><span> };</span><br><span> </span><br><span>diff --git a/include/osmocom/sgsn/gprs_sgsn.h b/include/osmocom/sgsn/gprs_sgsn.h</span><br><span>index 48c063d..17cafa3 100644</span><br><span>--- a/include/osmocom/sgsn/gprs_sgsn.h</span><br><span>+++ b/include/osmocom/sgsn/gprs_sgsn.h</span><br><span>@@ -3,6 +3,7 @@</span><br><span> </span><br><span> #include <stdint.h></span><br><span> #include <netinet/in.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <inttypes.h></span><br><span> </span><br><span> #include <osmocom/core/fsm.h></span><br><span> #include <osmocom/core/timer.h></span><br><span>@@ -405,6 +406,11 @@</span><br><span> void sgsn_ggsn_ctx_remove_pdp(struct sgsn_ggsn_ctx *ggc, struct sgsn_pdp_ctx *pdp);</span><br><span> void sgsn_ggsn_ctx_check_echo_timer(struct sgsn_ggsn_ctx *ggc);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#define LOGGGSN(ggc, level, fmt, args...) { \</span><br><span style="color: hsl(120, 100%, 40%);">+      char _buf[INET_ADDRSTRLEN]; \</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DGTP, level, "GGSN(%" PRIu32 ":%s): " fmt, (ggc)->id, inet_ntop(AF_INET, &(ggc)->remote_addr, _buf, sizeof(_buf)), ## args); \</span><br><span style="color: hsl(120, 100%, 40%);">+     } while (0)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> struct apn_ctx {</span><br><span>    struct llist_head list;</span><br><span>      struct sgsn_ggsn_ctx *ggsn;</span><br><span>diff --git a/src/gprs/sgsn_main.c b/src/gprs/sgsn_main.c</span><br><span>index 4232e23..9f2e111 100644</span><br><span>--- a/src/gprs/sgsn_main.c</span><br><span>+++ b/src/gprs/sgsn_main.c</span><br><span>@@ -340,7 +340,12 @@</span><br><span>              .name = "DV42BIS",</span><br><span>                 .description = "V.42bis data compression (SNDCP)",</span><br><span>                 .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span style="color: hsl(0, 100%, 40%);">-  }</span><br><span style="color: hsl(120, 100%, 40%);">+     },</span><br><span style="color: hsl(120, 100%, 40%);">+    [DGTP] = {</span><br><span style="color: hsl(120, 100%, 40%);">+            .name = "DGTP",</span><br><span style="color: hsl(120, 100%, 40%);">+             .description = "GPRS Tunnelling Protocol (GTP)",</span><br><span style="color: hsl(120, 100%, 40%);">+            .enabled = 1, .loglevel = LOGL_NOTICE,</span><br><span style="color: hsl(120, 100%, 40%);">+        },</span><br><span> };</span><br><span> </span><br><span> static const struct log_info gprs_log_info = {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15307">change 15307</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15307"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I30f46f44af1d0eee324b1a995c1dad2e1315af7c </div>
<div style="display:none"> Gerrit-Change-Number: 15307 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>