<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15174">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_gmm: gsm48_rx_gmm_att_req(): refactor duplicated code<br><br>Change-Id: I709f847802a975e1a75d0b87ac5125240cfd0854<br>---<br>M src/gprs/gprs_gmm.c<br>1 file changed, 6 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c</span><br><span>index 185cd9a..00335e8 100644</span><br><span>--- a/src/gprs/gprs_gmm.c</span><br><span>+++ b/src/gprs/gprs_gmm.c</span><br><span>@@ -1460,11 +1460,6 @@</span><br><span>                  }</span><br><span>                    osmo_strlcpy(ctx->imsi, mi_string, sizeof(ctx->imsi));</span><br><span>                 }</span><br><span style="color: hsl(0, 100%, 40%);">-               if (ctx->ran_type == MM_CTX_T_GERAN_Gb) {</span><br><span style="color: hsl(0, 100%, 40%);">-                    ctx->gb.tlli = msgb_tlli(msg);</span><br><span style="color: hsl(0, 100%, 40%);">-                       ctx->gb.llme = llme;</span><br><span style="color: hsl(0, 100%, 40%);">-         }</span><br><span style="color: hsl(0, 100%, 40%);">-               msgid2mmctx(ctx, msg);</span><br><span>               break;</span><br><span>       case GSM_MI_TYPE_TMSI:</span><br><span>               memcpy(&tmsi, mi+1, 4);</span><br><span>@@ -1485,11 +1480,6 @@</span><br><span>                         }</span><br><span>                    ctx->p_tmsi = tmsi;</span><br><span>               }</span><br><span style="color: hsl(0, 100%, 40%);">-               if (ctx->ran_type == MM_CTX_T_GERAN_Gb) {</span><br><span style="color: hsl(0, 100%, 40%);">-                    ctx->gb.tlli = msgb_tlli(msg);</span><br><span style="color: hsl(0, 100%, 40%);">-                       ctx->gb.llme = llme;</span><br><span style="color: hsl(0, 100%, 40%);">-         }</span><br><span style="color: hsl(0, 100%, 40%);">-               msgid2mmctx(ctx, msg);</span><br><span>               break;</span><br><span>       default:</span><br><span>             LOGMMCTXP(LOGL_NOTICE, ctx, "Rejecting ATTACH REQUEST with "</span><br><span>@@ -1497,6 +1487,12 @@</span><br><span>              reject_cause = GMM_CAUSE_MS_ID_NOT_DERIVED;</span><br><span>          goto rejected;</span><br><span>       }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+   if (ctx->ran_type == MM_CTX_T_GERAN_Gb) {</span><br><span style="color: hsl(120, 100%, 40%);">+          ctx->gb.tlli = msgb_tlli(msg);</span><br><span style="color: hsl(120, 100%, 40%);">+             ctx->gb.llme = llme;</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span style="color: hsl(120, 100%, 40%);">+     msgid2mmctx(ctx, msg);</span><br><span>       /* Update MM Context with currient RA and Cell ID */</span><br><span>         ctx->ra = ra_id;</span><br><span>  if (ctx->ran_type == MM_CTX_T_GERAN_Gb)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15174">change 15174</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15174"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I709f847802a975e1a75d0b87ac5125240cfd0854 </div>
<div style="display:none"> Gerrit-Change-Number: 15174 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>