<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15352">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_gmm.c: Replace inet_ntoa with inet_ntop<br><br>inet_ntop manual states:<br>"inet_ntoa(3) is now considered to be deprecated in favor of<br>inet_ntop()".<br><br>Change-Id: I0c708d047122f349acf46797a9e5973040e7ae04<br>---<br>M src/gprs/gprs_gmm.c<br>1 file changed, 8 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/52/15352/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c</span><br><span>index 9c5f689..766d0f4 100644</span><br><span>--- a/src/gprs/gprs_gmm.c</span><br><span>+++ b/src/gprs/gprs_gmm.c</span><br><span>@@ -118,10 +118,12 @@</span><br><span> </span><br><span> static void mmctx_change_gtpu_endpoints_to_sgsn(struct sgsn_mm_ctx *mm_ctx)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+     char buf[INET_ADDRSTRLEN];</span><br><span>   struct sgsn_pdp_ctx *pdp;</span><br><span>    llist_for_each_entry(pdp, &mm_ctx->pdp_list, list) {</span><br><span>          LOGMMCTXP(LOGL_INFO, mm_ctx, "Changing GTP-U endpoints %s -> %s\n",</span><br><span style="color: hsl(0, 100%, 40%);">-                          sgsn_gtp_ntoa(&pdp->lib->gsnlu), inet_ntoa(sgsn->cfg.gtp_listenaddr.sin_addr));</span><br><span style="color: hsl(120, 100%, 40%);">+                          sgsn_gtp_ntoa(&pdp->lib->gsnlu),</span><br><span style="color: hsl(120, 100%, 40%);">+                    inet_ntop(AF_INET, &sgsn->cfg.gtp_listenaddr.sin_addr, buf, sizeof(buf)));</span><br><span>          sgsn_pdp_upd_gtp_u(pdp,</span><br><span>                                 &sgsn->cfg.gtp_listenaddr.sin_addr,</span><br><span>                                   sizeof(sgsn->cfg.gtp_listenaddr.sin_addr));</span><br><span>@@ -2469,6 +2471,7 @@</span><br><span>    struct sgsn_ggsn_ctx *ggsn;</span><br><span>  struct sgsn_ggsn_lookup *lookup = arg;</span><br><span>       struct in_addr *addr = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+  char buf[INET_ADDRSTRLEN];</span><br><span> </span><br><span>       /* The context is gone while we made a request */</span><br><span>    if (!lookup->mmctx) {</span><br><span>@@ -2525,7 +2528,8 @@</span><br><span>     }</span><br><span>    ggsn->remote_addr = *addr;</span><br><span>        LOGMMCTXP(LOGL_NOTICE, lookup->mmctx,</span><br><span style="color: hsl(0, 100%, 40%);">-                "Selected %s as GGSN.\n", inet_ntoa(*addr));</span><br><span style="color: hsl(120, 100%, 40%);">+                  "Selected %s as GGSN.\n",</span><br><span style="color: hsl(120, 100%, 40%);">+           inet_ntop(AF_INET, addr, buf, sizeof(buf)));</span><br><span> </span><br><span>   /* forget about the ggsn look-up */</span><br><span>  lookup->mmctx->ggsn_lookup = NULL;</span><br><span>@@ -2561,6 +2565,7 @@</span><br><span>     char *hostname;</span><br><span>      int rc;</span><br><span>      struct gprs_llc_lle *lle;</span><br><span style="color: hsl(120, 100%, 40%);">+     char buf[INET_ADDRSTRLEN];</span><br><span> </span><br><span>       LOGMMCTXP(LOGL_INFO, mmctx, "-> ACTIVATE PDP CONTEXT REQ: SAPI=%u NSAPI=%u ",</span><br><span>           act_req->req_llc_sapi, act_req->req_nsapi);</span><br><span>@@ -2589,7 +2594,7 @@</span><br><span>            if (req_pdpa_len >= 6) {</span><br><span>                  struct in_addr ia;</span><br><span>                   ia.s_addr = ntohl(*((uint32_t *) (req_pdpa+2)));</span><br><span style="color: hsl(0, 100%, 40%);">-                        DEBUGPC(DMM, "%s ", inet_ntoa(ia));</span><br><span style="color: hsl(120, 100%, 40%);">+                 DEBUGPC(DMM, "%s ", inet_ntop(AF_INET, &ia, buf, sizeof(buf)));</span><br><span>                }</span><br><span>            break;</span><br><span>       case 0x57:</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15352">change 15352</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15352"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0c708d047122f349acf46797a9e5973040e7ae04 </div>
<div style="display:none"> Gerrit-Change-Number: 15352 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>