<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/15369">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gtp/gtp.c: cosmetic: use get_tid() where we need TID<br><br>Change-Id: I39e92f25ed51665c8a615826ed52f35024bdd54b<br>---<br>M gtp/gtp.c<br>1 file changed, 3 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/69/15369/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/gtp/gtp.c b/gtp/gtp.c</span><br><span>index 8b2373e..5af877c 100644</span><br><span>--- a/gtp/gtp.c</span><br><span>+++ b/gtp/gtp.c</span><br><span>@@ -1423,11 +1423,8 @@</span><br><span>       pdp = &pdp_buf;</span><br><span>  memset(pdp, 0, sizeof(struct pdp_t));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       if (version == 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-             uint64_t tid = be64toh(((union gtp_packet *)pack)->gtp0.h.tid);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-              pdp_set_imsi_nsapi(pdp, tid);</span><br><span style="color: hsl(0, 100%, 40%);">-   }</span><br><span style="color: hsl(120, 100%, 40%);">+     if (version == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+             pdp_set_imsi_nsapi(pdp, get_tid(pack));</span><br><span> </span><br><span>  pdp->seq = seq;</span><br><span>   pdp->sa_peer = *peer;</span><br><span>@@ -2737,7 +2734,7 @@</span><br><span> </span><br><span>         /* Find the context in question */</span><br><span>   if (version == 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-             if (gtp_pdp_tidget(gsn, &pdp, be64toh(((union gtp_packet *)pack)->gtp0.h.tid))) {</span><br><span style="color: hsl(120, 100%, 40%);">+              if (gtp_pdp_tidget(gsn, &pdp, get_tid(pack))) {</span><br><span>                  gsn->err_unknownpdp++;</span><br><span>                    GTP_LOGPKG(LOGL_ERROR, peer, pack, len,</span><br><span>                                  "Unknown PDP context\n");</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/15369">change 15369</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ggsn/+/15369"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ggsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I39e92f25ed51665c8a615826ed52f35024bdd54b </div>
<div style="display:none"> Gerrit-Change-Number: 15369 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>