<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/15368">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gtp_error_ind_conf(): fix: guard against an unknown GTP version<br><br>This change fixes the following compiler warnings (found by Clang):<br><br>  gtp.c:2747:13: warning: variable 'pdp' is used uninitialized<br>                     whenever 'if' condition is false<br>                      [-Wsometimes-uninitialized]<br>          } else if (version == 1) {<br><br>  gtp.c:2781:14: note: uninitialized use occurs here<br>            OSMO_ASSERT(pdp);<br>                         ^^^<br><br>Shall not happen in general, but let's make Clang happy.<br><br>Change-Id: Id471b22afd4c45435589a4edda0a804e66be3a7a<br>---<br>M gtp/gtp.c<br>1 file changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/68/15368/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/gtp/gtp.c b/gtp/gtp.c</span><br><span>index b18f76f..8b2373e 100644</span><br><span>--- a/gtp/gtp.c</span><br><span>+++ b/gtp/gtp.c</span><br><span>@@ -2768,6 +2768,9 @@</span><br><span>                       GTP_LOGPKG(LOGL_ERROR, peer, pack, len, "Unknown PDP context\n");</span><br><span>                  return EOF;</span><br><span>          }</span><br><span style="color: hsl(120, 100%, 40%);">+     } else {</span><br><span style="color: hsl(120, 100%, 40%);">+              LOGP(DLGTP, LOGL_ERROR, "Unknown version: %d\n", version);</span><br><span style="color: hsl(120, 100%, 40%);">+          return EOF;</span><br><span>  }</span><br><span> </span><br><span>        GTP_LOGPKG(LOGL_ERROR, peer, pack, len,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/15368">change 15368</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ggsn/+/15368"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ggsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id471b22afd4c45435589a4edda0a804e66be3a7a </div>
<div style="display:none"> Gerrit-Change-Number: 15368 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>