<p>laforge would like lynxis lazus to <strong>review</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/15359">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">change format of 'last LU seen'<br><br>So far, the time string format comes from ctime_r, and we manually add "UTC" to it.<br><br>The ctime_r format is wildly chaotic IMHO, mixing weekday, day-of-month and<br>hour and year in very unsorted ways.<br><br>Adding "UTC" to it is non-standard.<br><br>Instead use an ISO-8601 standardized time string via strftime().<br><br>Change-Id: I6731968f05050399f4dd43b241290186e0c59e1a<br>---<br>M src/hlr_vty_subscr.c<br>1 file changed, 8 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/59/15359/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/hlr_vty_subscr.c b/src/hlr_vty_subscr.c</span><br><span>index 73dfab6..b53227a 100644</span><br><span>--- a/src/hlr_vty_subscr.c</span><br><span>+++ b/src/hlr_vty_subscr.c</span><br><span>@@ -35,16 +35,15 @@</span><br><span> </span><br><span> #define hexdump_buf(buf) osmo_hexdump_nospc((void*)buf, sizeof(buf))</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-static char *</span><br><span style="color: hsl(0, 100%, 40%);">-get_datestr(const time_t *t, char *datebuf)</span><br><span style="color: hsl(120, 100%, 40%);">+static char *get_datestr(const time_t *t)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-       char *p, *s = ctime_r(t, datebuf);</span><br><span style="color: hsl(120, 100%, 40%);">+    static char buf[32];</span><br><span style="color: hsl(120, 100%, 40%);">+  struct tm tm;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-       /* Strip trailing newline. */</span><br><span style="color: hsl(0, 100%, 40%);">-   p = strchr(s, '\n');</span><br><span style="color: hsl(0, 100%, 40%);">-    if (p)</span><br><span style="color: hsl(0, 100%, 40%);">-          *p = '\0';</span><br><span style="color: hsl(0, 100%, 40%);">-      return s;</span><br><span style="color: hsl(120, 100%, 40%);">+     tm = *gmtime(t);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+    strftime(buf, sizeof(buf), "%FT%T+00:00", &tm);</span><br><span style="color: hsl(120, 100%, 40%);">+ return buf;</span><br><span> }</span><br><span> </span><br><span> static void subscr_dump_full_vty(struct vty *vty, struct hlr_subscriber *subscr)</span><br><span>@@ -52,7 +51,6 @@</span><br><span>         int rc;</span><br><span>      struct osmo_sub_auth_data aud2g;</span><br><span>     struct osmo_sub_auth_data aud3g;</span><br><span style="color: hsl(0, 100%, 40%);">-        char datebuf[26]; /* for ctime_r(3) */</span><br><span> </span><br><span>   vty_out(vty, "    ID: %"PRIu64"%s", subscr->id, VTY_NEWLINE);</span><br><span> </span><br><span>@@ -88,7 +86,7 @@</span><br><span>         if (subscr->ms_purged_ps)</span><br><span>                 vty_out(vty, "    PS purged%s", VTY_NEWLINE);</span><br><span>      if (subscr->last_lu_seen)</span><br><span style="color: hsl(0, 100%, 40%);">-            vty_out(vty, "    last LU seen: %s UTC%s", get_datestr(&subscr->last_lu_seen, datebuf), VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+                vty_out(vty, "    last LU seen: %s%s", get_datestr(&subscr->last_lu_seen), VTY_NEWLINE);</span><br><span> </span><br><span>        if (!*subscr->imsi)</span><br><span>               return;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hlr/+/15359">change 15359</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hlr/+/15359"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6731968f05050399f4dd43b241290186e0c59e1a </div>
<div style="display:none"> Gerrit-Change-Number: 15359 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>