<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15358">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sgsn_cdrc: Fix ip addr string buffer size<br><br>INET(6)_ADDRSTRLEN already contains the required extra null byte at the<br>end, no need to add +1 to it.<br><br>Change-Id: I5a16659e007c6883fe21582cce5dac544e6d4bb9<br>---<br>M src/gprs/sgsn_cdr.c<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/58/15358/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs/sgsn_cdr.c b/src/gprs/sgsn_cdr.c</span><br><span>index 93ed0af..a50b4df 100644</span><br><span>--- a/src/gprs/sgsn_cdr.c</span><br><span>+++ b/src/gprs/sgsn_cdr.c</span><br><span>@@ -153,9 +153,9 @@</span><br><span>                  struct sgsn_pdp_ctx *pdp)</span><br><span> {</span><br><span>       char apni[(pdp->lib ? pdp->lib->apn_use.l : 0) + 1];</span><br><span style="color: hsl(0, 100%, 40%);">-   char ggsn_addr[INET_ADDRSTRLEN + 1];</span><br><span style="color: hsl(0, 100%, 40%);">-    char sgsn_addr[INET_ADDRSTRLEN + 1];</span><br><span style="color: hsl(0, 100%, 40%);">-    char eua_addr[INET6_ADDRSTRLEN + 1];</span><br><span style="color: hsl(120, 100%, 40%);">+  char ggsn_addr[INET_ADDRSTRLEN];</span><br><span style="color: hsl(120, 100%, 40%);">+      char sgsn_addr[INET_ADDRSTRLEN];</span><br><span style="color: hsl(120, 100%, 40%);">+      char eua_addr[INET6_ADDRSTRLEN];</span><br><span>     struct tm tm;</span><br><span>        struct timeval tv;</span><br><span>   time_t duration;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15358">change 15358</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15358"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5a16659e007c6883fe21582cce5dac544e6d4bb9 </div>
<div style="display:none"> Gerrit-Change-Number: 15358 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>