<p>pespin <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15306">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
neels: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sgsn: Introduce test TC_attach_echo_timeout<br><br>This test verifies sgsn drops all GGSN related pdp context when that<br>GGSN stops answering echo requests.<br><br>Change-Id: Ic31748924e7bf05ea2ccf2b1be0c460eefed5782<br>---<br>M sgsn/SGSN_Tests.ttcn<br>M sgsn/expected-results.xml<br>2 files changed, 63 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn</span><br><span>index b146046..db7d54b 100644</span><br><span>--- a/sgsn/SGSN_Tests.ttcn</span><br><span>+++ b/sgsn/SGSN_Tests.ttcn</span><br><span>@@ -61,6 +61,7 @@</span><br><span> charstring mp_hlr_ip := "127.0.0.1";</span><br><span> integer mp_hlr_port := 4222;</span><br><span> charstring mp_ggsn_ip := "127.0.0.2";</span><br><span style="color: hsl(120, 100%, 40%);">+ integer mp_echo_interval := 5; /* in seconds. Only used in test enabling g_use_echo */</span><br><span> </span><br><span> NSConfigurations mp_nsconfig := {</span><br><span> {</span><br><span>@@ -259,7 +260,7 @@</span><br><span> </span><br><span> private function f_vty_enable_echo_interval(boolean enable) runs on test_CT {</span><br><span> if (enable) {</span><br><span style="color: hsl(0, 100%, 40%);">- f_vty_config(SGSNVTY, "sgsn", "ggsn 0 echo-interval 5");</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_config(SGSNVTY, "sgsn", "ggsn 0 echo-interval " & int2str(mp_echo_interval));</span><br><span> } else {</span><br><span> f_vty_config(SGSNVTY, "sgsn", "ggsn 0 no echo-interval");</span><br><span> }</span><br><span>@@ -1539,6 +1540,65 @@</span><br><span> vc_conn.done;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_attach_echo_timeout(charstring id) runs on BSSGP_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ var Gtp1cUnitdata g_ud;</span><br><span style="color: hsl(120, 100%, 40%);">+ var PdpActPars apars := valueof(t_PdpActPars(mp_ggsn_ip));</span><br><span style="color: hsl(120, 100%, 40%);">+ var integer seq_nr;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* first perform regular attach */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_TC_attach(id);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* then activate PDP context */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_pdp_ctx_act(apars);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Wait to receive first echo request and send initial Restart counter */</span><br><span style="color: hsl(120, 100%, 40%);">+ GTP.receive(tr_GTPC_MsgType(?, echoRequest, ?)) -> value g_ud {</span><br><span style="color: hsl(120, 100%, 40%);">+ BSSGP[0].clear;</span><br><span style="color: hsl(120, 100%, 40%);">+ seq_nr := oct2int(g_ud.gtpc.opt_part.sequenceNumber);</span><br><span style="color: hsl(120, 100%, 40%);">+ GTP.send(ts_GTPC_PONG(g_ud.peer, seq_nr, apars.ggsn_restart_ctr));</span><br><span style="color: hsl(120, 100%, 40%);">+ f_sleep(int2float(mp_echo_interval)); /* wait until around next echo is expected */</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* At some point next echo request not answered will timeout and SGSN</span><br><span style="color: hsl(120, 100%, 40%);">+ should drop the pdp ctx. Around T3 (3secs) * 6 (+ extra, a lot due to OS#4178): */</span><br><span style="color: hsl(120, 100%, 40%);">+ timer T := 3.0 * 6.0 + 16.0;</span><br><span style="color: hsl(120, 100%, 40%);">+ T.start;</span><br><span style="color: hsl(120, 100%, 40%);">+ alt {</span><br><span style="color: hsl(120, 100%, 40%);">+ [] BSSGP[0].receive(tr_SM_DEACT_PDP_REQ_MT(apars.tid, ?, true)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_send_l3_gmm_llc(ts_SM_DEACT_PDP_ACCEPT_MO(apars.tid));</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] GTP.receive(tr_GTPC_MsgType(?, deletePDPContextRequest, apars.ggsn_tei_c)) -> value g_ud {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* SGSN currently doesn't send this message because it expects GGSN to be non-reachable anyway */</span><br><span style="color: hsl(120, 100%, 40%);">+ seq_nr := oct2int(g_ud.gtpc.opt_part.sequenceNumber);</span><br><span style="color: hsl(120, 100%, 40%);">+ log("Received deletePDPContextRequest seq_nr=" & int2str(seq_nr));</span><br><span style="color: hsl(120, 100%, 40%);">+ GTP.send(ts_GTPC_DeletePdpResp(g_ud.peer, seq_nr, apars.sgsn_tei_c, '7F'O));</span><br><span style="color: hsl(120, 100%, 40%);">+ repeat;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] GTP.receive(tr_GTPC_MsgType(?, echoRequest, ?)) -> value g_ud {</span><br><span style="color: hsl(120, 100%, 40%);">+ seq_nr := oct2int(g_ud.gtpc.opt_part.sequenceNumber);</span><br><span style="color: hsl(120, 100%, 40%);">+ log("Received EchoRequest seq_nr=" & int2str(seq_nr));</span><br><span style="color: hsl(120, 100%, 40%);">+ repeat;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] T.timeout {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "BSSGP DeactPdpReq not received");</span><br><span style="color: hsl(120, 100%, 40%);">+ mtc.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] as_xid(apars);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ T.stop</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+/* ATTACH + trigger Recovery procedure through CreatePdpResp */</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_attach_echo_timeout() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSSGP_ConnHdlr vc_conn;</span><br><span style="color: hsl(120, 100%, 40%);">+ g_use_echo := true;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init();</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn := f_start_handler(refers(f_TC_attach_echo_timeout), testcasename(), g_gb, 67, 50.0);</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn.done;</span><br><span style="color: hsl(120, 100%, 40%);">+ g_use_echo := false;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> private function f_TC_attach_restart_ctr_echo(charstring id) runs on BSSGP_ConnHdlr {</span><br><span> var Gtp1cUnitdata g_ud;</span><br><span> var PdpActPars apars := valueof(t_PdpActPars(mp_ggsn_ip));</span><br><span>@@ -2597,6 +2657,7 @@</span><br><span> execute( TC_attach_pdp_act_user_deact_mt() );</span><br><span> execute( TC_attach_pdp_act_deact_dup() );</span><br><span> execute( TC_attach_second_attempt() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_attach_echo_timeout() );</span><br><span> execute( TC_attach_restart_ctr_echo() );</span><br><span> execute( TC_attach_restart_ctr_create() );</span><br><span> execute( TC_attach_pdp_act_deact_mt_t3395_expire() );</span><br><span>diff --git a/sgsn/expected-results.xml b/sgsn/expected-results.xml</span><br><span>index d9c3706..fc8856a 100644</span><br><span>--- a/sgsn/expected-results.xml</span><br><span>+++ b/sgsn/expected-results.xml</span><br><span>@@ -54,6 +54,7 @@</span><br><span> SGSN_Tests.ttcn:MASKED TC_attach_second_attempt testcase</span><br><span> </failure></span><br><span> </testcase></span><br><span style="color: hsl(120, 100%, 40%);">+ <testcase classname='SGSN_Tests' name='TC_attach_echo_timeout' time='MASKED'/></span><br><span> <testcase classname='SGSN_Tests' name='TC_attach_restart_ctr_echo' time='MASKED'/></span><br><span> <testcase classname='SGSN_Tests' name='TC_attach_restart_ctr_create' time='MASKED'/></span><br><span> <testcase classname='SGSN_Tests' name='TC_attach_pdp_act_deact_mt_t3395_expire' time='MASKED'/></span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15306">change 15306</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15306"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic31748924e7bf05ea2ccf2b1be0c460eefed5782 </div>
<div style="display:none"> Gerrit-Change-Number: 15306 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>