<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/15322">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cosmetic: gtp: Drop commented out code calling pdp_freepdp()<br><br>That code was commented out in 0b076a331e1e7f955580313a5da416c170b3b4ce<br>(year 2003), and indeed it makes no sense to call those in current pdp<br>lifecycle (they are expected to be freed by the application).<br><br>Change-Id: I096d8cb8d749ff9b737d6f3f96b1d423660ece37<br>---<br>M gtp/gtp.c<br>1 file changed, 0 insertions(+), 26 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/22/15322/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/gtp/gtp.c b/gtp/gtp.c</span><br><span>index 2ea949d..ba248c6 100644</span><br><span>--- a/gtp/gtp.c</span><br><span>+++ b/gtp/gtp.c</span><br><span>@@ -1752,8 +1752,6 @@</span><br><span>                          "Invalid message format\n");</span><br><span>           if (gsn->cb_conf)</span><br><span>                         gsn->cb_conf(type, EOF, pdp, cbp);</span><br><span style="color: hsl(0, 100%, 40%);">-           /*    if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);</span><br><span style="color: hsl(0, 100%, 40%);">-               pdp_freepdp(pdp); */</span><br><span>              return EOF;</span><br><span>  }</span><br><span> </span><br><span>@@ -1764,8 +1762,6 @@</span><br><span>                            "Missing mandatory information field\n");</span><br><span>              if (gsn->cb_conf)</span><br><span>                         gsn->cb_conf(type, EOF, pdp, cbp);</span><br><span style="color: hsl(0, 100%, 40%);">-           /*    if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);</span><br><span style="color: hsl(0, 100%, 40%);">-               pdp_freepdp(pdp); */</span><br><span>              return EOF;</span><br><span>  }</span><br><span> </span><br><span>@@ -1792,8 +1788,6 @@</span><br><span>                                            "Missing conditional information field\n");</span><br><span>                            if (gsn->cb_conf)</span><br><span>                                         gsn->cb_conf(type, EOF, pdp, cbp);</span><br><span style="color: hsl(0, 100%, 40%);">-                           /*    if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);</span><br><span style="color: hsl(0, 100%, 40%);">-                               pdp_freepdp(pdp); */</span><br><span>                              return EOF;</span><br><span>                  }</span><br><span>            }</span><br><span>@@ -1805,8 +1799,6 @@</span><br><span>                                "Missing conditional information field\n");</span><br><span>                    if (gsn->cb_conf)</span><br><span>                                 gsn->cb_conf(type, EOF, pdp, cbp);</span><br><span style="color: hsl(0, 100%, 40%);">-                   /*    if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);</span><br><span style="color: hsl(0, 100%, 40%);">-                       pdp_freepdp(pdp); */</span><br><span>                      return EOF;</span><br><span>          }</span><br><span> </span><br><span>@@ -1818,8 +1810,6 @@</span><br><span>                                            "Missing conditional information field\n");</span><br><span>                            if (gsn->cb_conf)</span><br><span>                                         gsn->cb_conf(type, EOF, pdp, cbp);</span><br><span style="color: hsl(0, 100%, 40%);">-                           /*    if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);</span><br><span style="color: hsl(0, 100%, 40%);">-                               pdp_freepdp(pdp); */</span><br><span>                              return EOF;</span><br><span>                  }</span><br><span> </span><br><span>@@ -1830,8 +1820,6 @@</span><br><span>                                            "Missing conditional information field\n");</span><br><span>                            if (gsn->cb_conf)</span><br><span>                                         gsn->cb_conf(type, EOF, pdp, cbp);</span><br><span style="color: hsl(0, 100%, 40%);">-                           /*    if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);</span><br><span style="color: hsl(0, 100%, 40%);">-                               pdp_freepdp(pdp); */</span><br><span>                              return EOF;</span><br><span>                  }</span><br><span>            }</span><br><span>@@ -1844,8 +1832,6 @@</span><br><span>                                        "Missing conditional information field\n");</span><br><span>                            if (gsn->cb_conf)</span><br><span>                                         gsn->cb_conf(type, EOF, pdp, cbp);</span><br><span style="color: hsl(0, 100%, 40%);">-                           /*    if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);</span><br><span style="color: hsl(0, 100%, 40%);">-                               pdp_freepdp(pdp); */</span><br><span>                              return EOF;</span><br><span>                  }</span><br><span> </span><br><span>@@ -1856,8 +1842,6 @@</span><br><span>                                            "Missing conditional information field\n");</span><br><span>                            if (gsn->cb_conf)</span><br><span>                                         gsn->cb_conf(type, EOF, pdp, cbp);</span><br><span style="color: hsl(0, 100%, 40%);">-                           /*    if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);</span><br><span style="color: hsl(0, 100%, 40%);">-                               pdp_freepdp(pdp); */</span><br><span>                              return EOF;</span><br><span>                  }</span><br><span>            }</span><br><span>@@ -1869,8 +1853,6 @@</span><br><span>                                "Missing conditional information field\n");</span><br><span>                    if (gsn->cb_conf)</span><br><span>                                 gsn->cb_conf(type, EOF, pdp, cbp);</span><br><span style="color: hsl(0, 100%, 40%);">-                   /*    if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);</span><br><span style="color: hsl(0, 100%, 40%);">-                       pdp_freepdp(pdp); */</span><br><span>              }</span><br><span> </span><br><span>                if (gtpie_gettlv(ie, GTPIE_EUA, 0, &pdp->eua.l,</span><br><span>@@ -1881,8 +1863,6 @@</span><br><span>                                   "Missing conditional information field\n");</span><br><span>                    if (gsn->cb_conf)</span><br><span>                                 gsn->cb_conf(type, EOF, pdp, cbp);</span><br><span style="color: hsl(0, 100%, 40%);">-                   /*    if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);</span><br><span style="color: hsl(0, 100%, 40%);">-                       pdp_freepdp(pdp); */</span><br><span>                      return EOF;</span><br><span>          }</span><br><span> </span><br><span>@@ -1894,8 +1874,6 @@</span><br><span>                                    "Missing conditional information field\n");</span><br><span>                    if (gsn->cb_conf)</span><br><span>                                 gsn->cb_conf(type, EOF, pdp, cbp);</span><br><span style="color: hsl(0, 100%, 40%);">-                   /*    if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);</span><br><span style="color: hsl(0, 100%, 40%);">-                       pdp_freepdp(pdp); */</span><br><span>                      return EOF;</span><br><span>          }</span><br><span> </span><br><span>@@ -1907,8 +1885,6 @@</span><br><span>                                    "Missing conditional information field\n");</span><br><span>                    if (gsn->cb_conf)</span><br><span>                                 gsn->cb_conf(type, EOF, pdp, cbp);</span><br><span style="color: hsl(0, 100%, 40%);">-                   /*    if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);</span><br><span style="color: hsl(0, 100%, 40%);">-                       pdp_freepdp(pdp); */</span><br><span>                      return EOF;</span><br><span>          }</span><br><span> </span><br><span>@@ -1922,8 +1898,6 @@</span><br><span>                                            "Missing conditional information field\n");</span><br><span>                            if (gsn->cb_conf)</span><br><span>                                         gsn->cb_conf(type, EOF, pdp, cbp);</span><br><span style="color: hsl(0, 100%, 40%);">-                           /*    if (gsn->cb_delete_context) gsn->cb_delete_context(pdp);</span><br><span style="color: hsl(0, 100%, 40%);">-                               pdp_freepdp(pdp); */</span><br><span>                              return EOF;</span><br><span>                  }</span><br><span>            }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/15322">change 15322</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ggsn/+/15322"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ggsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I096d8cb8d749ff9b737d6f3f96b1d423660ece37 </div>
<div style="display:none"> Gerrit-Change-Number: 15322 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>