<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/15209">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
neels: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm_08_08.c: always pick first msc for unsolicit paging responses<br><br>When osmo-bsc receives a paging response via the A-bis interface it<br>tries to find the MSC which is in charge for the paging. This is due to<br>the fact that osmo-bsc supports multiple msc connections, which is not<br>specified by 3gpp specs.<br><br>In an MT-CSFB call the MSC pages the UE via the SGs interface. Then the<br>UE falls back to 2G. It then reports back as MS on the A-Bis interface<br>with the paging response directly. In those cases osmo-bsc will not be<br>able to determine an MSC in charge, so we will forward the paging<br>response to the first configured MSC.<br><br>Change-Id: I7f091ed1bbc2afe12656e42031e122144eeb6826<br>Related: SYS#4624<br>---<br>M src/osmo-bsc/gsm_08_08.c<br>1 file changed, 16 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c</span><br><span>index 4dc4883..43117a8 100644</span><br><span>--- a/src/osmo-bsc/gsm_08_08.c</span><br><span>+++ b/src/osmo-bsc/gsm_08_08.c</span><br><span>@@ -323,8 +323,8 @@</span><br><span> subscr = extract_sub(conn, msg);</span><br><span> </span><br><span> if (!subscr) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGP(DMSC, LOGL_ERROR, "Got paged but no subscriber found.\n");</span><br><span style="color: hsl(0, 100%, 40%);">- return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DMSC, LOGL_INFO, "Got paging response but no subscriber found, will now (blindly) deliver the paging response to the first configured MSC!\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ goto blind;</span><br><span> }</span><br><span> </span><br><span> pag_msc = paging_get_msc(conn_get_bts(conn), subscr);</span><br><span>@@ -344,7 +344,20 @@</span><br><span> return msc;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- LOGP(DMSC, LOGL_ERROR, "Got paged but no request found.\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DMSC, LOGL_INFO, "Got paging response but no request found, will now (blindly) deliver the paging response to the first configured MSC!\n");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+blind:</span><br><span style="color: hsl(120, 100%, 40%);">+ /* In the case of an MT CSFB call we will get a paging response from</span><br><span style="color: hsl(120, 100%, 40%);">+ * the BTS without a preceding paging request via A-Interface. In those</span><br><span style="color: hsl(120, 100%, 40%);">+ * cases the MSC will page the subscriber via SGs interface, so the BSC</span><br><span style="color: hsl(120, 100%, 40%);">+ * can not know about the paging in advance. In those cases we can not</span><br><span style="color: hsl(120, 100%, 40%);">+ * know the MSC which is in charge. The only meaningful option we have</span><br><span style="color: hsl(120, 100%, 40%);">+ * is to deliver the paging response to the first configured MSC</span><br><span style="color: hsl(120, 100%, 40%);">+ * blindly. */</span><br><span style="color: hsl(120, 100%, 40%);">+ msc = llist_first_entry_or_null(&bsc->mscs, struct bsc_msc_data, entry);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (msc)</span><br><span style="color: hsl(120, 100%, 40%);">+ return msc;</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DMSC, LOGL_ERROR, "Unable to find any suitable MSC to deliver paging response!\n");</span><br><span> return NULL;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/15209">change 15209</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/15209"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7f091ed1bbc2afe12656e42031e122144eeb6826 </div>
<div style="display:none"> Gerrit-Change-Number: 15209 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>