<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/15246">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
osmith: Looks good to me, but someone else must approve
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ggsn: Move PCO handling code into its own file<br><br>This way ggsn.c is shrinked in size and get rid of a lot of code there,<br>which is of no interest unless the reader is interested in that really<br>specific part.<br><br>Change-Id: Ieaa7e71f17c7fd9377c76ef53362eab596d669a6<br>---<br>M ggsn/Makefile.am<br>M ggsn/ggsn.c<br>M ggsn/ggsn.h<br>A ggsn/pco.c<br>A ggsn/pco.h<br>5 files changed, 343 insertions(+), 312 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ggsn/Makefile.am b/ggsn/Makefile.am</span><br><span>index eca385f..022cdef 100644</span><br><span>--- a/ggsn/Makefile.am</span><br><span>+++ b/ggsn/Makefile.am</span><br><span>@@ -12,4 +12,4 @@</span><br><span> endif</span><br><span> </span><br><span> osmo_ggsn_DEPENDENCIES = ../gtp/libgtp.la ../lib/libmisc.a</span><br><span style="color: hsl(0, 100%, 40%);">-osmo_ggsn_SOURCES = ggsn_vty.c ggsn.c ggsn.h icmpv6.c icmpv6.h checksum.c checksum.h</span><br><span style="color: hsl(120, 100%, 40%);">+osmo_ggsn_SOURCES = ggsn_vty.c ggsn.c ggsn.h icmpv6.c icmpv6.h checksum.c checksum.h pco.c pco.h</span><br><span>diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c</span><br><span>index 99eae75..3c702c2 100644</span><br><span>--- a/ggsn/ggsn.c</span><br><span>+++ b/ggsn/ggsn.c</span><br><span>@@ -68,6 +68,7 @@</span><br><span> #include "../gtp/pdp.h"</span><br><span> #include "../gtp/gtp.h"</span><br><span> #include "icmpv6.h"</span><br><span style="color: hsl(120, 100%, 40%);">+#include "pco.h"</span><br><span> #include "ggsn.h"</span><br><span> </span><br><span> void *tall_ggsn_ctx;</span><br><span>@@ -79,14 +80,6 @@</span><br><span> struct ul255_t qos;</span><br><span> struct ul255_t apn;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#define LOGPAPN(level, apn, fmt, args...) \</span><br><span style="color: hsl(0, 100%, 40%);">- LOGP(DGGSN, level, "APN(%s): " fmt, (apn)->cfg.name, ## args)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#define LOGPGGSN(level, ggsn, fmt, args...) \</span><br><span style="color: hsl(0, 100%, 40%);">- LOGP(DGGSN, level, "GGSN(%s): " fmt, (ggsn)->cfg.name, ## args)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-#define LOGPPDP(level, pdp, fmt, args...) LOGPDPX(DGGSN, level, pdp, fmt, ## args)</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> static int ggsn_tun_fd_cb(struct osmo_fd *fd, unsigned int what);</span><br><span> static int cb_tun_ind(struct tun_t *tun, void *pack, unsigned len);</span><br><span> </span><br><span>@@ -396,92 +389,12 @@</span><br><span> return 0;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/gsm/tlv.h></span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/* RFC 1332 */</span><br><span style="color: hsl(0, 100%, 40%);">-enum ipcp_options {</span><br><span style="color: hsl(0, 100%, 40%);">- IPCP_OPT_IPADDR = 3,</span><br><span style="color: hsl(0, 100%, 40%);">- IPCP_OPT_PRIMARY_DNS = 129,</span><br><span style="color: hsl(0, 100%, 40%);">- IPCP_OPT_SECONDARY_DNS = 131,</span><br><span style="color: hsl(0, 100%, 40%);">-};</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-struct ipcp_option_hdr {</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t type;</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t len;</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t data[0];</span><br><span style="color: hsl(0, 100%, 40%);">-} __attribute__ ((packed));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-struct ipcp_hdr {</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t code;</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t id;</span><br><span style="color: hsl(0, 100%, 40%);">- uint16_t len;</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t options[0];</span><br><span style="color: hsl(0, 100%, 40%);">-} __attribute__ ((packed));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/* determine if IPCP contains given option */</span><br><span style="color: hsl(0, 100%, 40%);">-static const uint8_t *ipcp_contains_option(const struct ipcp_hdr *ipcp, size_t ipcp_len,</span><br><span style="color: hsl(0, 100%, 40%);">- enum ipcp_options opt, size_t opt_minlen)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- const uint8_t *cur_opt = ipcp->options;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* iterate over Options and check if protocol contained */</span><br><span style="color: hsl(0, 100%, 40%);">- while (cur_opt + sizeof(struct ipcp_option_hdr) <= (uint8_t*)ipcp + ipcp_len) {</span><br><span style="color: hsl(0, 100%, 40%);">- const struct ipcp_option_hdr *cur_opt_hdr = (const struct ipcp_option_hdr *)cur_opt;</span><br><span style="color: hsl(0, 100%, 40%);">- /* length value includes 2 bytes type/length */</span><br><span style="color: hsl(0, 100%, 40%);">- if (cur_opt_hdr->len < sizeof(struct ipcp_option_hdr))</span><br><span style="color: hsl(0, 100%, 40%);">- return NULL;</span><br><span style="color: hsl(0, 100%, 40%);">- if (cur_opt_hdr->type == opt &&</span><br><span style="color: hsl(0, 100%, 40%);">- cur_opt_hdr->len >= sizeof(struct ipcp_option_hdr) + opt_minlen)</span><br><span style="color: hsl(0, 100%, 40%);">- return cur_opt;</span><br><span style="color: hsl(0, 100%, 40%);">- cur_opt += cur_opt_hdr->len;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- return NULL;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/* 3GPP TS 24.008 10.6.5.3 */</span><br><span style="color: hsl(0, 100%, 40%);">-enum pco_protocols {</span><br><span style="color: hsl(0, 100%, 40%);">- PCO_P_LCP = 0xC021,</span><br><span style="color: hsl(0, 100%, 40%);">- PCO_P_PAP = 0xC023,</span><br><span style="color: hsl(0, 100%, 40%);">- PCO_P_CHAP = 0xC223,</span><br><span style="color: hsl(0, 100%, 40%);">- PCO_P_IPCP = 0x8021,</span><br><span style="color: hsl(0, 100%, 40%);">- PCO_P_PCSCF_ADDR = 0x0001,</span><br><span style="color: hsl(0, 100%, 40%);">- PCO_P_IM_CN_SS_F = 0x0002,</span><br><span style="color: hsl(0, 100%, 40%);">- PCO_P_DNS_IPv6_ADDR = 0x0003,</span><br><span style="color: hsl(0, 100%, 40%);">- PCO_P_POLICY_CTRL_REJ = 0x0004, /* only in Network->MS */</span><br><span style="color: hsl(0, 100%, 40%);">- PCO_P_MS_SUP_NETREQ_BCI = 0x0005,</span><br><span style="color: hsl(0, 100%, 40%);">- /* reserved */</span><br><span style="color: hsl(0, 100%, 40%);">- PCO_P_DSMIPv6_HA_ADDR = 0x0007,</span><br><span style="color: hsl(0, 100%, 40%);">- PCO_P_DSMIPv6_HN_PREF = 0x0008,</span><br><span style="color: hsl(0, 100%, 40%);">- PCO_P_DSMIPv6_v4_HA_ADDR= 0x0009,</span><br><span style="color: hsl(0, 100%, 40%);">- PCO_P_IP_ADDR_VIA_NAS = 0x000a, /* only MS->Network */</span><br><span style="color: hsl(0, 100%, 40%);">- PCO_P_IPv4_ADDR_VIA_DHCP= 0x000b, /* only MS->Netowrk */</span><br><span style="color: hsl(0, 100%, 40%);">- PCO_P_PCSCF_IPv4_ADDR = 0x000c,</span><br><span style="color: hsl(0, 100%, 40%);">- PCO_P_DNS_IPv4_ADDR = 0x000d,</span><br><span style="color: hsl(0, 100%, 40%);">- PCO_P_MSISDN = 0x000e,</span><br><span style="color: hsl(0, 100%, 40%);">- PCO_P_IFOM_SUPPORT = 0x000f,</span><br><span style="color: hsl(0, 100%, 40%);">- PCO_P_IPv4_LINK_MTU = 0x0010,</span><br><span style="color: hsl(0, 100%, 40%);">- PCO_P_MS_SUPP_LOC_A_TFT = 0x0011,</span><br><span style="color: hsl(0, 100%, 40%);">- PCO_P_PCSCF_RESEL_SUP = 0x0012, /* only MS->Network */</span><br><span style="color: hsl(0, 100%, 40%);">- PCO_P_NBIFOM_REQ = 0x0013,</span><br><span style="color: hsl(0, 100%, 40%);">- PCO_P_NBIFOM_MODE = 0x0014,</span><br><span style="color: hsl(0, 100%, 40%);">- PCO_P_NONIP_LINK_MTU = 0x0015,</span><br><span style="color: hsl(0, 100%, 40%);">- PCO_P_APN_RATE_CTRL_SUP = 0x0016,</span><br><span style="color: hsl(0, 100%, 40%);">- PCO_P_PS_DATA_OFF_UE = 0x0017,</span><br><span style="color: hsl(0, 100%, 40%);">- PCO_P_REL_DATA_SVC = 0x0018,</span><br><span style="color: hsl(0, 100%, 40%);">-};</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-struct pco_element {</span><br><span style="color: hsl(0, 100%, 40%);">- uint16_t protocol_id; /* network byte order */</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t length; /* length of data below */</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t data[0];</span><br><span style="color: hsl(0, 100%, 40%);">-} __attribute__((packed));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /*! Get the peer of pdp based on IP version used.</span><br><span> * \param[in] pdp PDP context to select the peer from.</span><br><span> * \param[in] v4v6 IP version to select. Valid values are 4 and 6.</span><br><span> * \returns The selected peer matching the given IP version. NULL if not present.</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">-static struct ippoolm_t *pdp_get_peer_ipv(struct pdp_t *pdp, bool is_ipv6) {</span><br><span style="color: hsl(120, 100%, 40%);">+struct ippoolm_t *pdp_get_peer_ipv(struct pdp_t *pdp, bool is_ipv6) {</span><br><span> uint8_t i;</span><br><span> </span><br><span> for (i = 0; i < 2; i++) {</span><br><span>@@ -496,228 +409,6 @@</span><br><span> return NULL;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* RFC 1334, section 3.2. Packet Format */</span><br><span style="color: hsl(0, 100%, 40%);">-struct pap_element {</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t code;</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t id;</span><br><span style="color: hsl(0, 100%, 40%);">- uint16_t len; /* length including header */</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t data[0];</span><br><span style="color: hsl(0, 100%, 40%);">-} __attribute__((packed));</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-enum pap_code {</span><br><span style="color: hsl(0, 100%, 40%);">- PAP_CODE_AUTH_REQ = 1,</span><br><span style="color: hsl(0, 100%, 40%);">- PAP_CODE_AUTH_ACK = 2,</span><br><span style="color: hsl(0, 100%, 40%);">- PAP_CODE_AUTH_NAK = 3,</span><br><span style="color: hsl(0, 100%, 40%);">-};</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-static const char *pap_welcome = "Welcome to OsmoGGSN " PACKAGE_VERSION;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/* Handle PAP protocol according to RFC 1334 */</span><br><span style="color: hsl(0, 100%, 40%);">-static void process_pco_element_pap(const struct pco_element *pco_in, struct msgb *resp,</span><br><span style="color: hsl(0, 100%, 40%);">- const struct apn_ctx *apn, struct pdp_t *pdp)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- const struct pap_element *pap_in = (const struct pap_element *) pco_in->data;</span><br><span style="color: hsl(0, 100%, 40%);">- uint16_t pap_in_len;</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t peer_id_len;</span><br><span style="color: hsl(0, 100%, 40%);">- const uint8_t *peer_id;</span><br><span style="color: hsl(0, 100%, 40%);">- unsigned int pap_welcome_len;</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t pap_out_size;</span><br><span style="color: hsl(0, 100%, 40%);">- struct pap_element *pap_out;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if (pco_in->length < sizeof(struct pap_element))</span><br><span style="color: hsl(0, 100%, 40%);">- goto ret_broken;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- pap_in_len = osmo_load16be(&pap_in->len);</span><br><span style="color: hsl(0, 100%, 40%);">- if (pco_in->length < pap_in_len)</span><br><span style="color: hsl(0, 100%, 40%);">- goto ret_broken;</span><br><span style="color: hsl(0, 100%, 40%);">- /* "pco_in->length > pap_in_len" is allowed: RFC1334 2.2 states:</span><br><span style="color: hsl(0, 100%, 40%);">- "Octets outside the range of the Length field should be treated as</span><br><span style="color: hsl(0, 100%, 40%);">- Data Link Layer padding and should be ignored on reception."</span><br><span style="color: hsl(0, 100%, 40%);">- */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- switch (pap_in->code) {</span><br><span style="color: hsl(0, 100%, 40%);">- case PAP_CODE_AUTH_REQ:</span><br><span style="color: hsl(0, 100%, 40%);">- if (pap_in_len < sizeof(struct pap_element) + 1)</span><br><span style="color: hsl(0, 100%, 40%);">- goto ret_broken_auth;</span><br><span style="color: hsl(0, 100%, 40%);">- peer_id_len = pap_in->data[0];</span><br><span style="color: hsl(0, 100%, 40%);">- if (pap_in_len < sizeof(struct pap_element) + 1 + peer_id_len)</span><br><span style="color: hsl(0, 100%, 40%);">- goto ret_broken_auth;</span><br><span style="color: hsl(0, 100%, 40%);">- peer_id = &pap_in->data[1];</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPPDP(LOGL_DEBUG, pdp, "PCO PAP PeerId = %s, ACKing\n",</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_quote_str((const char *)peer_id, peer_id_len));</span><br><span style="color: hsl(0, 100%, 40%);">- /* Password-Length + Password following here, but we don't care */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* Prepare response, we ACK all of them: */</span><br><span style="color: hsl(0, 100%, 40%);">- pap_welcome_len = strlen(pap_welcome);</span><br><span style="color: hsl(0, 100%, 40%);">- /* +1: Length field of pap_welcome Message */</span><br><span style="color: hsl(0, 100%, 40%);">- pap_out_size = sizeof(struct pap_element) + 1 + pap_welcome_len;</span><br><span style="color: hsl(0, 100%, 40%);">- pap_out = alloca(pap_out_size);</span><br><span style="color: hsl(0, 100%, 40%);">- pap_out->code = PAP_CODE_AUTH_ACK;</span><br><span style="color: hsl(0, 100%, 40%);">- pap_out->id = pap_in->id;</span><br><span style="color: hsl(0, 100%, 40%);">- pap_out->len = htons(pap_out_size);</span><br><span style="color: hsl(0, 100%, 40%);">- pap_out->data[0] = pap_welcome_len;</span><br><span style="color: hsl(0, 100%, 40%);">- memcpy(pap_out->data+1, pap_welcome, pap_welcome_len);</span><br><span style="color: hsl(0, 100%, 40%);">- msgb_t16lv_put(resp, PCO_P_PAP, pap_out_size, (uint8_t *) pap_out);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case PAP_CODE_AUTH_ACK:</span><br><span style="color: hsl(0, 100%, 40%);">- case PAP_CODE_AUTH_NAK:</span><br><span style="color: hsl(0, 100%, 40%);">- default:</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPPDP(LOGL_NOTICE, pdp, "Unsupported PAP PCO Code %u, ignoring\n", pap_in->code);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- return;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-ret_broken_auth:</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPPDP(LOGL_NOTICE, pdp, "Invalid PAP AuthenticateReq: %s, ignoring\n",</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_hexdump_nospc((const uint8_t *)pco_in, pco_in->length));</span><br><span style="color: hsl(0, 100%, 40%);">- return;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-ret_broken:</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPPDP(LOGL_NOTICE, pdp, "Invalid PAP PCO Length: %s, ignoring\n",</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_hexdump_nospc((const uint8_t *)pco_in, pco_in->length));</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-static void process_pco_element_ipcp(const struct pco_element *pco_elem, struct msgb *resp,</span><br><span style="color: hsl(0, 100%, 40%);">- const struct apn_ctx *apn, struct pdp_t *pdp)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- struct ippoolm_t *peer_v4 = pdp_get_peer_ipv(pdp, false);</span><br><span style="color: hsl(0, 100%, 40%);">- const struct in46_addr *dns1 = &apn->v4.cfg.dns[0];</span><br><span style="color: hsl(0, 100%, 40%);">- const struct in46_addr *dns2 = &apn->v4.cfg.dns[1];</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t *start = resp->tail;</span><br><span style="color: hsl(0, 100%, 40%);">- const struct ipcp_hdr *ipcp;</span><br><span style="color: hsl(0, 100%, 40%);">- uint16_t ipcp_len;</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t *len1, *len2;</span><br><span style="color: hsl(0, 100%, 40%);">- unsigned int len_appended;</span><br><span style="color: hsl(0, 100%, 40%);">- ptrdiff_t consumed;</span><br><span style="color: hsl(0, 100%, 40%);">- size_t remain;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if (!peer_v4) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPPDP(LOGL_ERROR, pdp, "IPCP but no IPv4 type ?!?\n");</span><br><span style="color: hsl(0, 100%, 40%);">- return;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- ipcp = (const struct ipcp_hdr *)pco_elem->data;</span><br><span style="color: hsl(0, 100%, 40%);">- consumed = (pco_elem->data - &pdp->pco_req.v[0]);</span><br><span style="color: hsl(0, 100%, 40%);">- remain = sizeof(pdp->pco_req.v) - consumed;</span><br><span style="color: hsl(0, 100%, 40%);">- ipcp_len = osmo_load16be(&ipcp->len);</span><br><span style="color: hsl(0, 100%, 40%);">- if (remain < 0 || remain < ipcp_len) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPPDP(LOGL_ERROR, pdp, "Malformed IPCP, ignoring\n");</span><br><span style="color: hsl(0, 100%, 40%);">- return;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* Three byte T16L header */</span><br><span style="color: hsl(0, 100%, 40%);">- msgb_put_u16(resp, 0x8021); /* IPCP */</span><br><span style="color: hsl(0, 100%, 40%);">- len1 = msgb_put(resp, 1); /* Length of contents: delay */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- msgb_put_u8(resp, 0x02); /* ACK */</span><br><span style="color: hsl(0, 100%, 40%);">- msgb_put_u8(resp, ipcp->id); /* ID: Needs to match request */</span><br><span style="color: hsl(0, 100%, 40%);">- msgb_put_u8(resp, 0x00); /* Length MSB */</span><br><span style="color: hsl(0, 100%, 40%);">- len2 = msgb_put(resp, 1); /* Length LSB: delay */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if (dns1->len == 4 && ipcp_contains_option(ipcp, ipcp_len, IPCP_OPT_PRIMARY_DNS, 4)) {</span><br><span style="color: hsl(0, 100%, 40%);">- msgb_put_u8(resp, 0x81); /* DNS1 Tag */</span><br><span style="color: hsl(0, 100%, 40%);">- msgb_put_u8(resp, 2 + dns1->len); /* DNS1 Length, incl. TL */</span><br><span style="color: hsl(0, 100%, 40%);">- msgb_put_u32(resp, ntohl(dns1->v4.s_addr));</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- if (dns2->len == 4 && ipcp_contains_option(ipcp, ipcp_len, IPCP_OPT_SECONDARY_DNS, 4)) {</span><br><span style="color: hsl(0, 100%, 40%);">- msgb_put_u8(resp, 0x83); /* DNS2 Tag */</span><br><span style="color: hsl(0, 100%, 40%);">- msgb_put_u8(resp, 2 + dns2->len); /* DNS2 Length, incl. TL */</span><br><span style="color: hsl(0, 100%, 40%);">- msgb_put_u32(resp, ntohl(dns2->v4.s_addr));</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* patch in length values */</span><br><span style="color: hsl(0, 100%, 40%);">- len_appended = resp->tail - start;</span><br><span style="color: hsl(0, 100%, 40%);">- *len1 = len_appended - 3;</span><br><span style="color: hsl(0, 100%, 40%);">- *len2 = len_appended - 3;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-static void process_pco_element_dns_ipv6(const struct pco_element *pco_elem, struct msgb *resp,</span><br><span style="color: hsl(0, 100%, 40%);">- const struct apn_ctx *apn, struct pdp_t *pdp)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- unsigned int i;</span><br><span style="color: hsl(0, 100%, 40%);">- const uint8_t *tail = resp->tail;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- for (i = 0; i < ARRAY_SIZE(apn->v6.cfg.dns); i++) {</span><br><span style="color: hsl(0, 100%, 40%);">- const struct in46_addr *i46a = &apn->v6.cfg.dns[i];</span><br><span style="color: hsl(0, 100%, 40%);">- if (i46a->len != 16)</span><br><span style="color: hsl(0, 100%, 40%);">- continue;</span><br><span style="color: hsl(0, 100%, 40%);">- msgb_t16lv_put(resp, PCO_P_DNS_IPv6_ADDR, i46a->len, i46a->v6.s6_addr);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- if (resp->tail == tail)</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPPDP(LOGL_NOTICE, pdp, "MS requested IPv6 DNS, but APN has none configured\n");</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-static void process_pco_element_dns_ipv4(const struct pco_element *pco_elem, struct msgb *resp,</span><br><span style="color: hsl(0, 100%, 40%);">- const struct apn_ctx *apn, struct pdp_t *pdp)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- unsigned int i;</span><br><span style="color: hsl(0, 100%, 40%);">- const uint8_t *tail = resp->tail;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- for (i = 0; i < ARRAY_SIZE(apn->v4.cfg.dns); i++) {</span><br><span style="color: hsl(0, 100%, 40%);">- const struct in46_addr *i46a = &apn->v4.cfg.dns[i];</span><br><span style="color: hsl(0, 100%, 40%);">- if (i46a->len != 4)</span><br><span style="color: hsl(0, 100%, 40%);">- continue;</span><br><span style="color: hsl(0, 100%, 40%);">- msgb_t16lv_put(resp, PCO_P_DNS_IPv4_ADDR, i46a->len, (uint8_t *)&i46a->v4);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- if (resp->tail == tail)</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPPDP(LOGL_NOTICE, pdp, "MS requested IPv4 DNS, but APN has none configured\n");</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-static void process_pco_element(const struct pco_element *pco_elem, struct msgb *resp,</span><br><span style="color: hsl(0, 100%, 40%);">- const struct apn_ctx *apn, struct pdp_t *pdp)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- uint16_t protocol_id = osmo_load16be(&pco_elem->protocol_id);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPPDP(LOGL_DEBUG, pdp, "PCO Protocol 0x%04x\n", protocol_id);</span><br><span style="color: hsl(0, 100%, 40%);">- switch (protocol_id) {</span><br><span style="color: hsl(0, 100%, 40%);">- case PCO_P_PAP:</span><br><span style="color: hsl(0, 100%, 40%);">- process_pco_element_pap(pco_elem, resp, apn, pdp);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case PCO_P_IPCP:</span><br><span style="color: hsl(0, 100%, 40%);">- process_pco_element_ipcp(pco_elem, resp, apn, pdp);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case PCO_P_DNS_IPv6_ADDR:</span><br><span style="color: hsl(0, 100%, 40%);">- process_pco_element_dns_ipv6(pco_elem, resp, apn, pdp);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- case PCO_P_DNS_IPv4_ADDR:</span><br><span style="color: hsl(0, 100%, 40%);">- process_pco_element_dns_ipv4(pco_elem, resp, apn, pdp);</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- default:</span><br><span style="color: hsl(0, 100%, 40%);">- LOGPPDP(LOGL_INFO, pdp, "Unknown/Unimplemented PCO Protocol 0x%04x: %s\n",</span><br><span style="color: hsl(0, 100%, 40%);">- protocol_id, osmo_hexdump_nospc(pco_elem->data, pco_elem->length));</span><br><span style="color: hsl(0, 100%, 40%);">- break;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-/* process one PCO request from a MS/UE, putting together the proper responses */</span><br><span style="color: hsl(0, 100%, 40%);">-static void process_pco(const struct apn_ctx *apn, struct pdp_t *pdp)</span><br><span style="color: hsl(0, 100%, 40%);">-{</span><br><span style="color: hsl(0, 100%, 40%);">- struct msgb *resp = msgb_alloc(256, "PCO.resp");</span><br><span style="color: hsl(0, 100%, 40%);">- const struct ul255_t *pco = &pdp->pco_req;</span><br><span style="color: hsl(0, 100%, 40%);">- const struct pco_element *pco_elem;</span><br><span style="color: hsl(0, 100%, 40%);">- const uint8_t *cur;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* build the header of the PCO response */</span><br><span style="color: hsl(0, 100%, 40%);">- OSMO_ASSERT(resp);</span><br><span style="color: hsl(0, 100%, 40%);">- msgb_put_u8(resp, 0x80); /* ext-bit + configuration protocol byte */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* iterate over the PCO elements in the request; call process_pco_element() for each */</span><br><span style="color: hsl(0, 100%, 40%);">- for (cur = pco->v + 1, pco_elem = (const struct pco_element *) cur;</span><br><span style="color: hsl(0, 100%, 40%);">- cur + sizeof(struct pco_element) <= pco->v + pco->l;</span><br><span style="color: hsl(0, 100%, 40%);">- cur += pco_elem->length + sizeof(*pco_elem), pco_elem = (const struct pco_element *) cur) {</span><br><span style="color: hsl(0, 100%, 40%);">- process_pco_element(pco_elem, resp, apn, pdp);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* copy the PCO response msgb and copy its contents over to the PDP context */</span><br><span style="color: hsl(0, 100%, 40%);">- if (msgb_length(resp) > 1) {</span><br><span style="color: hsl(0, 100%, 40%);">- memcpy(pdp->pco_neg.v, msgb_data(resp), msgb_length(resp));</span><br><span style="color: hsl(0, 100%, 40%);">- pdp->pco_neg.l = msgb_length(resp);</span><br><span style="color: hsl(0, 100%, 40%);">- } else</span><br><span style="color: hsl(0, 100%, 40%);">- pdp->pco_neg.l = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- msgb_free(resp);</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> static bool apn_supports_ipv4(const struct apn_ctx *apn)</span><br><span> {</span><br><span> if (apn->v4.cfg.static_prefix.addr.len || apn->v4.cfg.dynamic_prefix.addr.len)</span><br><span>diff --git a/ggsn/ggsn.h b/ggsn/ggsn.h</span><br><span>index 09cd0f6..a37381f 100644</span><br><span>--- a/ggsn/ggsn.h</span><br><span>+++ b/ggsn/ggsn.h</span><br><span>@@ -141,3 +141,12 @@</span><br><span> extern int ggsn_stop(struct ggsn_ctx *ggsn);</span><br><span> extern int apn_start(struct apn_ctx *apn);</span><br><span> extern int apn_stop(struct apn_ctx *apn);</span><br><span style="color: hsl(120, 100%, 40%);">+extern struct ippoolm_t *pdp_get_peer_ipv(struct pdp_t *pdp, bool is_ipv6);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define LOGPAPN(level, apn, fmt, args...) \</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DGGSN, level, "APN(%s): " fmt, (apn)->cfg.name, ## args)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define LOGPGGSN(level, ggsn, fmt, args...) \</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DGGSN, level, "GGSN(%s): " fmt, (ggsn)->cfg.name, ## args)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define LOGPPDP(level, pdp, fmt, args...) LOGPDPX(DGGSN, level, pdp, fmt, ## args)</span><br><span>diff --git a/ggsn/pco.c b/ggsn/pco.c</span><br><span>new file mode 100644</span><br><span>index 0000000..5715865</span><br><span>--- /dev/null</span><br><span>+++ b/ggsn/pco.c</span><br><span>@@ -0,0 +1,250 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * PCO parsing related code</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright (C) 2002, 2003, 2004 Mondru AB.</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright (C) 2017-2019 by Harald Welte <laforge@gnumonks.org></span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright (C) 2019 sysmocom - s.f.m.c. GmbH <info@sysmocom.de></span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * The contents of this file may be used under the terms of the GNU</span><br><span style="color: hsl(120, 100%, 40%);">+ * General Public License Version 2, provided that the above copyright</span><br><span style="color: hsl(120, 100%, 40%);">+ * notice and this permission notice is included in all copies or</span><br><span style="color: hsl(120, 100%, 40%);">+ * substantial portions of the software.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <unistd.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <string.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/msgb.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/gsm/tlv.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include "pco.h"</span><br><span style="color: hsl(120, 100%, 40%);">+#include "ggsn.h"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* determine if IPCP contains given option */</span><br><span style="color: hsl(120, 100%, 40%);">+static const uint8_t *ipcp_contains_option(const struct ipcp_hdr *ipcp, size_t ipcp_len,</span><br><span style="color: hsl(120, 100%, 40%);">+ enum ipcp_options opt, size_t opt_minlen)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ const uint8_t *cur_opt = ipcp->options;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* iterate over Options and check if protocol contained */</span><br><span style="color: hsl(120, 100%, 40%);">+ while (cur_opt + sizeof(struct ipcp_option_hdr) <= (uint8_t*)ipcp + ipcp_len) {</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct ipcp_option_hdr *cur_opt_hdr = (const struct ipcp_option_hdr *)cur_opt;</span><br><span style="color: hsl(120, 100%, 40%);">+ /* length value includes 2 bytes type/length */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (cur_opt_hdr->len < sizeof(struct ipcp_option_hdr))</span><br><span style="color: hsl(120, 100%, 40%);">+ return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (cur_opt_hdr->type == opt &&</span><br><span style="color: hsl(120, 100%, 40%);">+ cur_opt_hdr->len >= sizeof(struct ipcp_option_hdr) + opt_minlen)</span><br><span style="color: hsl(120, 100%, 40%);">+ return cur_opt;</span><br><span style="color: hsl(120, 100%, 40%);">+ cur_opt += cur_opt_hdr->len;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static const char *pap_welcome = "Welcome to OsmoGGSN " PACKAGE_VERSION;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Handle PAP protocol according to RFC 1334 */</span><br><span style="color: hsl(120, 100%, 40%);">+static void process_pco_element_pap(const struct pco_element *pco_in, struct msgb *resp,</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct apn_ctx *apn, struct pdp_t *pdp)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct pap_element *pap_in = (const struct pap_element *) pco_in->data;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint16_t pap_in_len;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t peer_id_len;</span><br><span style="color: hsl(120, 100%, 40%);">+ const uint8_t *peer_id;</span><br><span style="color: hsl(120, 100%, 40%);">+ unsigned int pap_welcome_len;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t pap_out_size;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct pap_element *pap_out;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (pco_in->length < sizeof(struct pap_element))</span><br><span style="color: hsl(120, 100%, 40%);">+ goto ret_broken;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ pap_in_len = osmo_load16be(&pap_in->len);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (pco_in->length < pap_in_len)</span><br><span style="color: hsl(120, 100%, 40%);">+ goto ret_broken;</span><br><span style="color: hsl(120, 100%, 40%);">+ /* "pco_in->length > pap_in_len" is allowed: RFC1334 2.2 states:</span><br><span style="color: hsl(120, 100%, 40%);">+ "Octets outside the range of the Length field should be treated as</span><br><span style="color: hsl(120, 100%, 40%);">+ Data Link Layer padding and should be ignored on reception."</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (pap_in->code) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case PAP_CODE_AUTH_REQ:</span><br><span style="color: hsl(120, 100%, 40%);">+ if (pap_in_len < sizeof(struct pap_element) + 1)</span><br><span style="color: hsl(120, 100%, 40%);">+ goto ret_broken_auth;</span><br><span style="color: hsl(120, 100%, 40%);">+ peer_id_len = pap_in->data[0];</span><br><span style="color: hsl(120, 100%, 40%);">+ if (pap_in_len < sizeof(struct pap_element) + 1 + peer_id_len)</span><br><span style="color: hsl(120, 100%, 40%);">+ goto ret_broken_auth;</span><br><span style="color: hsl(120, 100%, 40%);">+ peer_id = &pap_in->data[1];</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPPDP(LOGL_DEBUG, pdp, "PCO PAP PeerId = %s, ACKing\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_quote_str((const char *)peer_id, peer_id_len));</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Password-Length + Password following here, but we don't care */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Prepare response, we ACK all of them: */</span><br><span style="color: hsl(120, 100%, 40%);">+ pap_welcome_len = strlen(pap_welcome);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* +1: Length field of pap_welcome Message */</span><br><span style="color: hsl(120, 100%, 40%);">+ pap_out_size = sizeof(struct pap_element) + 1 + pap_welcome_len;</span><br><span style="color: hsl(120, 100%, 40%);">+ pap_out = alloca(pap_out_size);</span><br><span style="color: hsl(120, 100%, 40%);">+ pap_out->code = PAP_CODE_AUTH_ACK;</span><br><span style="color: hsl(120, 100%, 40%);">+ pap_out->id = pap_in->id;</span><br><span style="color: hsl(120, 100%, 40%);">+ pap_out->len = htons(pap_out_size);</span><br><span style="color: hsl(120, 100%, 40%);">+ pap_out->data[0] = pap_welcome_len;</span><br><span style="color: hsl(120, 100%, 40%);">+ memcpy(pap_out->data+1, pap_welcome, pap_welcome_len);</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_t16lv_put(resp, PCO_P_PAP, pap_out_size, (uint8_t *) pap_out);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case PAP_CODE_AUTH_ACK:</span><br><span style="color: hsl(120, 100%, 40%);">+ case PAP_CODE_AUTH_NAK:</span><br><span style="color: hsl(120, 100%, 40%);">+ default:</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPPDP(LOGL_NOTICE, pdp, "Unsupported PAP PCO Code %u, ignoring\n", pap_in->code);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ return;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ret_broken_auth:</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPPDP(LOGL_NOTICE, pdp, "Invalid PAP AuthenticateReq: %s, ignoring\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_hexdump_nospc((const uint8_t *)pco_in, pco_in->length));</span><br><span style="color: hsl(120, 100%, 40%);">+ return;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ret_broken:</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPPDP(LOGL_NOTICE, pdp, "Invalid PAP PCO Length: %s, ignoring\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_hexdump_nospc((const uint8_t *)pco_in, pco_in->length));</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void process_pco_element_ipcp(const struct pco_element *pco_elem, struct msgb *resp,</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct apn_ctx *apn, struct pdp_t *pdp)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct ippoolm_t *peer_v4 = pdp_get_peer_ipv(pdp, false);</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct in46_addr *dns1 = &apn->v4.cfg.dns[0];</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct in46_addr *dns2 = &apn->v4.cfg.dns[1];</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t *start = resp->tail;</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct ipcp_hdr *ipcp;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint16_t ipcp_len;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t *len1, *len2;</span><br><span style="color: hsl(120, 100%, 40%);">+ unsigned int len_appended;</span><br><span style="color: hsl(120, 100%, 40%);">+ ptrdiff_t consumed;</span><br><span style="color: hsl(120, 100%, 40%);">+ size_t remain;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!peer_v4) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPPDP(LOGL_ERROR, pdp, "IPCP but no IPv4 type ?!?\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ return;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ ipcp = (const struct ipcp_hdr *)pco_elem->data;</span><br><span style="color: hsl(120, 100%, 40%);">+ consumed = (pco_elem->data - &pdp->pco_req.v[0]);</span><br><span style="color: hsl(120, 100%, 40%);">+ remain = sizeof(pdp->pco_req.v) - consumed;</span><br><span style="color: hsl(120, 100%, 40%);">+ ipcp_len = osmo_load16be(&ipcp->len);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (remain < 0 || remain < ipcp_len) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPPDP(LOGL_ERROR, pdp, "Malformed IPCP, ignoring\n");</span><br><span style="color: hsl(120, 100%, 40%);">+ return;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Three byte T16L header */</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_put_u16(resp, 0x8021); /* IPCP */</span><br><span style="color: hsl(120, 100%, 40%);">+ len1 = msgb_put(resp, 1); /* Length of contents: delay */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_put_u8(resp, 0x02); /* ACK */</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_put_u8(resp, ipcp->id); /* ID: Needs to match request */</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_put_u8(resp, 0x00); /* Length MSB */</span><br><span style="color: hsl(120, 100%, 40%);">+ len2 = msgb_put(resp, 1); /* Length LSB: delay */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (dns1->len == 4 && ipcp_contains_option(ipcp, ipcp_len, IPCP_OPT_PRIMARY_DNS, 4)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_put_u8(resp, 0x81); /* DNS1 Tag */</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_put_u8(resp, 2 + dns1->len); /* DNS1 Length, incl. TL */</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_put_u32(resp, ntohl(dns1->v4.s_addr));</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (dns2->len == 4 && ipcp_contains_option(ipcp, ipcp_len, IPCP_OPT_SECONDARY_DNS, 4)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_put_u8(resp, 0x83); /* DNS2 Tag */</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_put_u8(resp, 2 + dns2->len); /* DNS2 Length, incl. TL */</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_put_u32(resp, ntohl(dns2->v4.s_addr));</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* patch in length values */</span><br><span style="color: hsl(120, 100%, 40%);">+ len_appended = resp->tail - start;</span><br><span style="color: hsl(120, 100%, 40%);">+ *len1 = len_appended - 3;</span><br><span style="color: hsl(120, 100%, 40%);">+ *len2 = len_appended - 3;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void process_pco_element_dns_ipv6(const struct pco_element *pco_elem, struct msgb *resp,</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct apn_ctx *apn, struct pdp_t *pdp)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ unsigned int i;</span><br><span style="color: hsl(120, 100%, 40%);">+ const uint8_t *tail = resp->tail;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < ARRAY_SIZE(apn->v6.cfg.dns); i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct in46_addr *i46a = &apn->v6.cfg.dns[i];</span><br><span style="color: hsl(120, 100%, 40%);">+ if (i46a->len != 16)</span><br><span style="color: hsl(120, 100%, 40%);">+ continue;</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_t16lv_put(resp, PCO_P_DNS_IPv6_ADDR, i46a->len, i46a->v6.s6_addr);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ if (resp->tail == tail)</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPPDP(LOGL_NOTICE, pdp, "MS requested IPv6 DNS, but APN has none configured\n");</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void process_pco_element_dns_ipv4(const struct pco_element *pco_elem, struct msgb *resp,</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct apn_ctx *apn, struct pdp_t *pdp)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ unsigned int i;</span><br><span style="color: hsl(120, 100%, 40%);">+ const uint8_t *tail = resp->tail;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < ARRAY_SIZE(apn->v4.cfg.dns); i++) {</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct in46_addr *i46a = &apn->v4.cfg.dns[i];</span><br><span style="color: hsl(120, 100%, 40%);">+ if (i46a->len != 4)</span><br><span style="color: hsl(120, 100%, 40%);">+ continue;</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_t16lv_put(resp, PCO_P_DNS_IPv4_ADDR, i46a->len, (uint8_t *)&i46a->v4);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ if (resp->tail == tail)</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPPDP(LOGL_NOTICE, pdp, "MS requested IPv4 DNS, but APN has none configured\n");</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void process_pco_element(const struct pco_element *pco_elem, struct msgb *resp,</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct apn_ctx *apn, struct pdp_t *pdp)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ uint16_t protocol_id = osmo_load16be(&pco_elem->protocol_id);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPPDP(LOGL_DEBUG, pdp, "PCO Protocol 0x%04x\n", protocol_id);</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (protocol_id) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCO_P_PAP:</span><br><span style="color: hsl(120, 100%, 40%);">+ process_pco_element_pap(pco_elem, resp, apn, pdp);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCO_P_IPCP:</span><br><span style="color: hsl(120, 100%, 40%);">+ process_pco_element_ipcp(pco_elem, resp, apn, pdp);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCO_P_DNS_IPv6_ADDR:</span><br><span style="color: hsl(120, 100%, 40%);">+ process_pco_element_dns_ipv6(pco_elem, resp, apn, pdp);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case PCO_P_DNS_IPv4_ADDR:</span><br><span style="color: hsl(120, 100%, 40%);">+ process_pco_element_dns_ipv4(pco_elem, resp, apn, pdp);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ default:</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPPDP(LOGL_INFO, pdp, "Unknown/Unimplemented PCO Protocol 0x%04x: %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ protocol_id, osmo_hexdump_nospc(pco_elem->data, pco_elem->length));</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* process one PCO request from a MS/UE, putting together the proper responses */</span><br><span style="color: hsl(120, 100%, 40%);">+void process_pco(const struct apn_ctx *apn, struct pdp_t *pdp)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ struct msgb *resp = msgb_alloc(256, "PCO.resp");</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct ul255_t *pco = &pdp->pco_req;</span><br><span style="color: hsl(120, 100%, 40%);">+ const struct pco_element *pco_elem;</span><br><span style="color: hsl(120, 100%, 40%);">+ const uint8_t *cur;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* build the header of the PCO response */</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(resp);</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_put_u8(resp, 0x80); /* ext-bit + configuration protocol byte */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* iterate over the PCO elements in the request; call process_pco_element() for each */</span><br><span style="color: hsl(120, 100%, 40%);">+ for (cur = pco->v + 1, pco_elem = (const struct pco_element *) cur;</span><br><span style="color: hsl(120, 100%, 40%);">+ cur + sizeof(struct pco_element) <= pco->v + pco->l;</span><br><span style="color: hsl(120, 100%, 40%);">+ cur += pco_elem->length + sizeof(*pco_elem), pco_elem = (const struct pco_element *) cur) {</span><br><span style="color: hsl(120, 100%, 40%);">+ process_pco_element(pco_elem, resp, apn, pdp);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* copy the PCO response msgb and copy its contents over to the PDP context */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (msgb_length(resp) > 1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ memcpy(pdp->pco_neg.v, msgb_data(resp), msgb_length(resp));</span><br><span style="color: hsl(120, 100%, 40%);">+ pdp->pco_neg.l = msgb_length(resp);</span><br><span style="color: hsl(120, 100%, 40%);">+ } else</span><br><span style="color: hsl(120, 100%, 40%);">+ pdp->pco_neg.l = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_free(resp);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span>diff --git a/ggsn/pco.h b/ggsn/pco.h</span><br><span>new file mode 100644</span><br><span>index 0000000..7ebe05a</span><br><span>--- /dev/null</span><br><span>+++ b/ggsn/pco.h</span><br><span>@@ -0,0 +1,81 @@</span><br><span style="color: hsl(120, 100%, 40%);">+#pragma once</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <stdint.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include "../gtp/pdp.h"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* 3GPP TS 24.008 10.6.5.3 */</span><br><span style="color: hsl(120, 100%, 40%);">+enum pco_protocols {</span><br><span style="color: hsl(120, 100%, 40%);">+ PCO_P_LCP = 0xC021,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCO_P_PAP = 0xC023,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCO_P_CHAP = 0xC223,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCO_P_IPCP = 0x8021,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCO_P_PCSCF_ADDR = 0x0001,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCO_P_IM_CN_SS_F = 0x0002,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCO_P_DNS_IPv6_ADDR = 0x0003,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCO_P_POLICY_CTRL_REJ = 0x0004, /* only in Network->MS */</span><br><span style="color: hsl(120, 100%, 40%);">+ PCO_P_MS_SUP_NETREQ_BCI = 0x0005,</span><br><span style="color: hsl(120, 100%, 40%);">+ /* reserved */</span><br><span style="color: hsl(120, 100%, 40%);">+ PCO_P_DSMIPv6_HA_ADDR = 0x0007,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCO_P_DSMIPv6_HN_PREF = 0x0008,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCO_P_DSMIPv6_v4_HA_ADDR= 0x0009,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCO_P_IP_ADDR_VIA_NAS = 0x000a, /* only MS->Network */</span><br><span style="color: hsl(120, 100%, 40%);">+ PCO_P_IPv4_ADDR_VIA_DHCP= 0x000b, /* only MS->Netowrk */</span><br><span style="color: hsl(120, 100%, 40%);">+ PCO_P_PCSCF_IPv4_ADDR = 0x000c,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCO_P_DNS_IPv4_ADDR = 0x000d,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCO_P_MSISDN = 0x000e,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCO_P_IFOM_SUPPORT = 0x000f,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCO_P_IPv4_LINK_MTU = 0x0010,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCO_P_MS_SUPP_LOC_A_TFT = 0x0011,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCO_P_PCSCF_RESEL_SUP = 0x0012, /* only MS->Network */</span><br><span style="color: hsl(120, 100%, 40%);">+ PCO_P_NBIFOM_REQ = 0x0013,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCO_P_NBIFOM_MODE = 0x0014,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCO_P_NONIP_LINK_MTU = 0x0015,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCO_P_APN_RATE_CTRL_SUP = 0x0016,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCO_P_PS_DATA_OFF_UE = 0x0017,</span><br><span style="color: hsl(120, 100%, 40%);">+ PCO_P_REL_DATA_SVC = 0x0018,</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+struct pco_element {</span><br><span style="color: hsl(120, 100%, 40%);">+ uint16_t protocol_id; /* network byte order */</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t length; /* length of data below */</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t data[0];</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* RFC 1332 */</span><br><span style="color: hsl(120, 100%, 40%);">+enum ipcp_options {</span><br><span style="color: hsl(120, 100%, 40%);">+ IPCP_OPT_IPADDR = 3,</span><br><span style="color: hsl(120, 100%, 40%);">+ IPCP_OPT_PRIMARY_DNS = 129,</span><br><span style="color: hsl(120, 100%, 40%);">+ IPCP_OPT_SECONDARY_DNS = 131,</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+struct ipcp_option_hdr {</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t type;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t len;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t data[0];</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__ ((packed));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+struct ipcp_hdr {</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t code;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t id;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint16_t len;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t options[0];</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__ ((packed));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* RFC 1334, section 3.2. Packet Format */</span><br><span style="color: hsl(120, 100%, 40%);">+struct pap_element {</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t code;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t id;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint16_t len; /* length including header */</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t data[0];</span><br><span style="color: hsl(120, 100%, 40%);">+} __attribute__((packed));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+enum pap_code {</span><br><span style="color: hsl(120, 100%, 40%);">+ PAP_CODE_AUTH_REQ = 1,</span><br><span style="color: hsl(120, 100%, 40%);">+ PAP_CODE_AUTH_ACK = 2,</span><br><span style="color: hsl(120, 100%, 40%);">+ PAP_CODE_AUTH_NAK = 3,</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+struct apn_ctx;</span><br><span style="color: hsl(120, 100%, 40%);">+void process_pco(const struct apn_ctx *apn, struct pdp_t *pdp);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/15246">change 15246</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ggsn/+/15246"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ggsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ieaa7e71f17c7fd9377c76ef53362eab596d669a6 </div>
<div style="display:none"> Gerrit-Change-Number: 15246 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>