<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15325">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gtp: cb_delete_context(): Clarify why pdp->lib is set to NULL<br><br>Change-Id: I02c46062d6dc9802d9cae057587e66a68a65436c<br>---<br>M src/gprs/sgsn_libgtp.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/25/15325/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs/sgsn_libgtp.c b/src/gprs/sgsn_libgtp.c</span><br><span>index ac4b7b1..a8ad527 100644</span><br><span>--- a/src/gprs/sgsn_libgtp.c</span><br><span>+++ b/src/gprs/sgsn_libgtp.c</span><br><span>@@ -652,8 +652,9 @@</span><br><span> </span><br><span>  LOGPDPX(DGPRS, LOGL_INFO, pdp, "Context %p was deleted\n", pdp);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  /* unlink the now non-existing library handle from the pdp</span><br><span style="color: hsl(0, 100%, 40%);">-       * context */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* unlink the now non-existing library handle from the pdp context.</span><br><span style="color: hsl(120, 100%, 40%);">+      This way we avoid calling pdp_freepdp() on it, since after returning</span><br><span style="color: hsl(120, 100%, 40%);">+          from cb_delete_context callback, libgtp is already doing so. */</span><br><span>   pctx->lib = NULL;</span><br><span> </span><br><span>     sgsn_ggsn_ctx_drop_pdp(pctx);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15325">change 15325</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15325"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I02c46062d6dc9802d9cae057587e66a68a65436c </div>
<div style="display:none"> Gerrit-Change-Number: 15325 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>