<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/15277">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  pespin: Looks good to me, approved
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">abis_nm.c: use LOGP() macro instead of LOGPC()<br><br>The LOGPC() is usually used for continuation when printing complex<br>logging messages (e.g. where using format string is not enough).<br>In this case, nothing is being printed before calling LOGPC(), so<br>the logging messages appear without the meta info (time-stamp,<br>level, category, etc.), for example:<br><br>  BTS 0 reported connected PCU version 0.7.0.1-2585-dirty<br><br>Change-Id: I868633ad3e50f2cb3ebfb2c566d16c4710f17563<br>---<br>M src/osmo-bsc/abis_nm.c<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c</span><br><span>index 7d059b5..48e9183 100644</span><br><span>--- a/src/osmo-bsc/abis_nm.c</span><br><span>+++ b/src/osmo-bsc/abis_nm.c</span><br><span>@@ -311,7 +311,7 @@</span><br><span>     enum abis_nm_pcause_type pcause = p_val[0];</span><br><span>  enum abis_mm_event_causes cause = osmo_load16be(p_val + 1);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- LOGPC(DNM, LOGL_ERROR, "BTS %u: Failure Event Report: ", bts->nr);</span><br><span style="color: hsl(120, 100%, 40%);">+       LOGP(DNM, LOGL_ERROR, "BTS %u: Failure Event Report: ", bts->nr);</span><br><span>       if (type)</span><br><span>            LOGPC(DNM, LOGL_ERROR, "Type=%s, ", type);</span><br><span>         if (severity)</span><br><span>@@ -341,10 +341,10 @@</span><br><span>        switch (cause) {</span><br><span>     case OSMO_EVT_PCU_VERS:</span><br><span>              if (text) {</span><br><span style="color: hsl(0, 100%, 40%);">-                     LOGPC(DNM, LOGL_NOTICE, "BTS %u reported connected PCU version %s\n", bts->nr, text);</span><br><span style="color: hsl(120, 100%, 40%);">+                    LOGP(DNM, LOGL_NOTICE, "BTS %u reported connected PCU version %s\n", bts->nr, text);</span><br><span>                    osmo_strlcpy(bts->pcu_version, text, sizeof(bts->pcu_version));</span><br><span>                } else {</span><br><span style="color: hsl(0, 100%, 40%);">-                        LOGPC(DNM, LOGL_ERROR, "BTS %u reported PCU disconnection.\n", bts->nr);</span><br><span style="color: hsl(120, 100%, 40%);">+                 LOGP(DNM, LOGL_ERROR, "BTS %u reported PCU disconnection.\n", bts->nr);</span><br><span>                         bts->pcu_version[0] = '\0';</span><br><span>               }</span><br><span>            break;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/15277">change 15277</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/15277"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I868633ad3e50f2cb3ebfb2c566d16c4710f17563 </div>
<div style="display:none"> Gerrit-Change-Number: 15277 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>