<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/15288">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/15288/2/Transceiver52M/Transceiver.cpp">File Transceiver52M/Transceiver.cpp:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/15288/2/Transceiver52M/Transceiver.cpp@932">Patch Set #2, Line 932:</a> <code style="font-family:monospace,monospace">EDGE_BURST_NBITS + 50</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This size could be also corrected as a part of this change.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/15288/2/Transceiver52M/Transceiver.cpp@944">Patch Set #2, Line 944:</a> <code style="font-family:monospace,monospace">trxd_hdr_v01_dl</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Cosmetic (feel free to keep as is): sizeof(*dl).</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/15288/2/Transceiver52M/proto_trxd.h">File Transceiver52M/proto_trxd.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/15288/2/Transceiver52M/proto_trxd.h@72">Patch Set #2, Line 72:</a> <code style="font-family:monospace,monospace">rssi</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This is not RSSI. Either call it 'tx_att' (Tx Attenuation), or 'pwr'.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/15288">change 15288</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/15288"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4d8c0e3c0c717699889f79e50c778d14b6058f2d </div>
<div style="display:none"> Gerrit-Change-Number: 15288 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 26 Aug 2019 10:29:45 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>